[Ruby 3.2] Enable most tests for Socket::AF_UNIX and test for File.socket? on Windows #1300
Conversation
trinistr
force-pushed
the
3.2-unixsocket-windows
branch
7 times, most recently
from
f3ec3c8 to
f87cf33
Compare
trinistr
force-pushed
the
3.2-unixsocket-windows
branch
4 times, most recently
from
51d1c32 to
8092a25
Compare
| @path1 = SocketSpecs.socket_path | ||
| @path2 = SocketSpecs.socket_path.chop + '2' | ||
| rm_r(@path2) | ||
|
|
||
| @client_raw = Socket.new(:UNIX, :DGRAM) | ||
| @client_raw.bind(Socket.sockaddr_un(@path1)) | ||
| @client_raw = Socket.new(:UNIX, :DGRAM) | ||
| @client_raw.bind(Socket.sockaddr_un(@path1)) | ||
|
|
||
| @server_raw = Socket.new(:UNIX, :DGRAM) | ||
| @server_raw.bind(Socket.sockaddr_un(@path2)) | ||
| @server_raw = Socket.new(:UNIX, :DGRAM) | ||
| @server_raw.bind(Socket.sockaddr_un(@path2)) |
There was a problem hiding this comment.
It probably should be possible to rewrite this using :STREAM sockets but just changing the type doesn't work.
library/socket/shared/address.rb
Outdated
| else | ||
| # see https://bugs.ruby-lang.org/issues/21702 | ||
| @addr.unix_path.should == @b.local_address.unix_path | ||
| end |
There was a problem hiding this comment.
There is a special guard ruby_bug for such cases. It will not run a guarded test case on MRI but will on other Ruby implementations
From the contributing guide (#13669 is an id of the corresponding reported issue):
ruby_bug '#13669', ''...'3.2' do
it "works like this" do
# Specify the expected behavior here, not the bug
end
endThere was a problem hiding this comment.
Ah, forgot about it. Though, the guide says "If [bugfix] is not backported or not likely, use ruby_version_is instead." (I don't understand the point about backporting? It will still be some minimum version.), and in any case version to expect the fix in is unknown currently. Does this PR need to be parked until someone can get on the bug?
There was a problem hiding this comment.
ruby_bug guard indicates that there is no any value for alternative Ruby implementations to follow the current CRuby's incorrect behaviour. If an issue isn't being fixed in CRuby and backported to the supported versions - this behaviour becomes a feature so alternative implementations need to implement it as well.
In this case it's definitely a bug and I suppose it will be fixed very soon.
Does this PR need to be parked until someone can get on the bug?
No.
As I wrote above the ruby_bug guard prevents running this case on CRuby so CI will be green. After fixing and backporting the guard is supposed to be removed. And the next release version (4.0) can be used temporary as a fixed Ruby version.
There was a problem hiding this comment.
Thank you for the clarification!
There was a problem hiding this comment.
Hello again!
Bug https://bugs.ruby-lang.org/issues/21702 was marked as "third party issue". Clearly, it won't be fixed in 4.0, and may not be fixed at all. So it's a feature now? I'm thinking of removing ruby_bug guard, or at least ruby_version_is. What's your opinion?
There was a problem hiding this comment.
I replied there, I think it's a CRuby bug so let's leave it as-is for now.
If other implementations have the same problem they can easily change the guard/adjust the spec as necessary.
There was a problem hiding this comment.
Alright, thank you!
trinistr
force-pushed
the
3.2-unixsocket-windows
branch
from
8092a25 to
ba50fc1
Compare
Previously, it was just a fancy :windows platform guard. Unix sockets are now mostly implemented on Windows, making the feature useless.
trinistr
force-pushed
the
3.2-unixsocket-windows
branch
from
ba50fc1 to
1d0c365
Compare
|
Thank you! |
3 participants
From #1016
File.socket?FileTest.socket?is actually tested.#to_path.Following things are not supported so the tests are disabled:
#send_io,#recv_io,#getpeerid(UNIX IDs),Socket pairs are emulated using a temporary file (ruby/ruby#6513 (comment)), so the behavior is different. Trying to create a Socket using a non-existent path raises a different error for whatever reason.
There are a couple bugs, reported as https://bugs.ruby-lang.org/issues/21702:
#remote_address.to_sreturns 110 bytes always;#recvfromreturns 2047 bytes of garbage as the remote address.