Skip to content

Fix ruby-lsp url on documentation index #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fix ruby-lsp url on documentation index #3468

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2997e3e
Fix ruby-lsp url
riseshia Jan 12, 2025
2c82d0b
Move shopify_lsp link source under ruby-lsp
riseshia Jan 13, 2025
070401d
Improve ruby-lsp/editors.html link ref
riseshia Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion en/documentation/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,8 @@ These links were more prominent but haven't been updated in ages.
[pickaxe]: https://pragprog.com/titles/ruby5/programming-ruby-3-3-5th-edition/
[poodr]: https://www.poodr.com/
[ruby-lsp]: https://github.com/Shopify/ruby-lsp
[shopify_lsp]: https://shopify.github.io/ruby-lsp/editors.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project isn't called Shopify LSP so let's change the name:

Suggested change
[shopify_lsp]: https://shopify.github.io/ruby-lsp/editors.html
[ruby-lsp-supported-editors]: https://shopify.github.io/ruby-lsp/editors.html

Remember to update all the references to it too 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I missed it. fixed 070401d

[rubyapi-org]: https://rubyapi.org/
[rubyin20]: https://www.ruby-lang.org/en/documentation/quickstart/
[shopify_lsp]: https://shopify.github.io/ruby-lsp/editors.html)
[vscode]: https://code.visualstudio.com/docs/languages/ruby
[zed]: https://zed.dev/
Loading