Skip to content

Conversation

@jackboberg
Copy link
Contributor

  • chore: Add [email protected] to dev dependencies
  • test: Use indoc to improve string formatting
    • allows testing stdout explicitly
    • makes doc blocks more readable

));

.stdout(predicate::str::starts_with("Error: file is owned by multiple teams!"))
// order not static
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to ensure this output is always in an expected order.

const DEFAULT_CODE_OWNERSHIP_YML: &str = indoc! {"
---
owned_globs:
- \"{app,components,config,frontend,lib,packs,spec}/**/*.{rb,rake,js,jsx,ts,tsx,json,yml}\"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs and spaces mixed 🤔 ❓

Copy link
Contributor

@perryqh perryqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@perryqh perryqh merged commit d14ee3d into rubyatscale:main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants