Skip to content

Conversation

@technicalpickles
Copy link
Contributor

Currently, https://github.com/rubyatscale/code-ownership-vscode uses bin/codeownership to check the ownership to display. I was making some other changes, and thought maybe we could be using --json. We don't have that yet.

As an aside, it seems like that looking up a single for-file is about the same as gv, which is interesting. I was thinking about if there's an opportunity to make this an LSP? Or maybe just a long lived client/server so there isn't up front lookup cost.

@pbomb
Copy link

pbomb commented Aug 20, 2025

@perryqh I see that this PR is old at this point and might be outdated, but Adding this functionality would be great. I would like to get https://github.com/rubyatscale/code-ownership-vscode working without the Ruby CodeOwnership gem and just directly calling this library and one of the differences (besides for_file vs for-file) is that this library doesn't support the --json flag. Are there any plans to land this functionality?

@perryqh
Copy link
Contributor

perryqh commented Aug 22, 2025

@perryqh I see that this PR is old at this point and might be outdated, but Adding this functionality would be great. I would like to get https://github.com/rubyatscale/code-ownership-vscode working without the Ruby CodeOwnership gem and just directly calling this library and one of the differences (besides for_file vs for-file) is that this library doesn't support the --json flag. Are there any plans to land this functionality?

Good to know @pbomb! We can definitely add --json support!

@perryqh
Copy link
Contributor

perryqh commented Sep 5, 2025

@perryqh perryqh closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants