Skip to content

Skip injecting extensions on frame switch to prevent javascript errors #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
route merged 2 commits into from
Mar 5, 2025
Merged

Skip injecting extensions on frame switch to prevent javascript errors #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c7b800
Do not inject extensions on every frame switch, they were already inj…
Jun 24, 2022
cfbcdca
Use @session to access the driver
hoffi Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/capybara/cuprite/page.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ def switch_to_frame(handle)
@frame_stack = []
else
@frame_stack << handle
inject_extensions
end
end

Expand Down
12 changes: 12 additions & 0 deletions spec/features/session_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,18 @@
expect(e).to be_a(Capybara::ElementNotFound)
end)
end

it "generates no javascript errors when switching into a frame" do
@session.driver.browser.evaluate_on_new_document(
"window.errors ||= []; window.onerror = function(msg) { window.errors += msg; };"
)

@session.visit "/cuprite/frames"
@session.within_frame(0) do
expect(@session.evaluate_script("window.errors")).to be_empty
end
expect(@session.evaluate_script("window.errors")).to be_empty
end
end

it "handles obsolete node during an attach_file" do
Expand Down