Enable mobile emulation #292
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-bayne
force-pushed
the
216-mobile-emulation
branch
3 times, most recently
from
d2de7e2 to
410be86
Compare
duncan-bayne
force-pushed
the
216-mobile-emulation
branch
from
410be86 to
cc67c32
Compare
We need to expose the mobile setting in the Ferrum API as well. Until that's merged, use a fork of Ferrum that exposes it.
This tests for mobile emulation by: * Checking that text controlled by a CSS media query is / isn't visible. * Checking that touch input is enabled / disabled.
These were (a) trying to use a non-existent session, and (b) trying to set both `mobile: true` and a resolution, which is now disallowed.
duncan-bayne
force-pushed
the
216-mobile-emulation
branch
from
cc67c32 to
d2405cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 WIP - do not merge 🚨
Currently, when creating a Cuprite driver, it's not possible to specify that it should have mobile emulation enabled.
This PR adds that functionality.
Remember to revert 5117a90 once rubycdp/ferrum#527 is merged.