issue#229 add option 'by' for Node#select to picks option by provided attribute

Author: Mifrill

lib/ferrum/node.rb

@@ -142,17 +142,17 @@ def selected
       page.evaluate_func(function, self)
     end
 
-    def select(*values)
+    def select(*values, by: :value)
       tap do
         function = <<~JS
-          function(element, values) {
+          function(element, values, by) {
             if (element.nodeName.toLowerCase() !== 'select') {
               throw new Error('Element is not a <select> element.');
             }
             const options = Array.from(element.options);
             element.value = undefined;
             for (const option of options) {
-              option.selected = values.includes(option.value);
+              option.selected = values.includes(option[by]);
               if (option.selected && !element.multiple) break;
             }
             element.dispatchEvent(new Event('input', { bubbles: true }));
@@ -162,7 +162,7 @@ def select(*values)
               .map((option) => option.value);
           }
         JS
-        page.evaluate_func(function, self, values.join(","))
+        page.evaluate_func(function, self, values.join(","), by)
       end
     end
 

spec/node_spec.rb

@@ -171,6 +171,13 @@ module Ferrum
           expect(browser.at_xpath("//*[@id='form_title']").select(["Other"]).selected.map(&:text)).to eq(["Other"])
         end
       end
+
+      context "when option with text and value" do
+        it "picks option in select by matched text" do
+          expect(browser.at_xpath("//select[@id='form_locale']").select("Swedish", by: :text).selected.map(&:value)).
+            to eq(["sv"])
+        end
+      end
     end
 
     context "when the element is not in the viewport" do