Skip to content

Conversation

@bradleyscollins
Copy link
Contributor

This pull request adds an API that exposes CDP's screencast capability.

See the following:

Note: At this time, the Chrome DevTools Protocol documentation still has screencast methods/types marked as "experimental."

@bradleyscollins
Copy link
Contributor Author

A number of the test failures are on account of a difference between expected vs. actual screenshot height.

We noticed that as of Chrome 128, the heights of our screenshot/screencast images were different from (less than) the height specified in the window_size option of the Browser constructor. We had to set the viewport size explicitly to get the expected screenshot height.

@route
Copy link
Member

route commented Nov 20, 2024

@bradleyscollins could you please rebase on master? after that we can merge, should be fixed in there

@bradleyscollins
Copy link
Contributor Author

@route, I think I have rebased correctly (and fixed a brittle test). Just let me know if there's anything else you need me to do.

And thank you for your kind consideration of my pull request.

@vojtad
Copy link

vojtad commented Feb 25, 2025

Hello, is there anything I can do to help to get this merged? We would like to use the Screencast API for debugging flaky tests. Thanks!

@route route merged commit 6a682f5 into rubycdp:main Mar 5, 2025
6 of 7 checks passed
@route
Copy link
Member

route commented Mar 5, 2025

Thank you!

@bradleyscollins
Copy link
Contributor Author

Yes, indeed, my thanks to you as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants