Skip to content

Add additional theme layouts for events #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add additional theme layouts for events #362

wants to merge 1 commit into from

Conversation

devonharless
Copy link
Contributor

  • Add V1 of the about template for future conferences
  • Add routing to preview theme pages outside of the conference website builder to ease development and design
  • Make theme pages only available after auth

@devonharless
Add additional theme layouts for events
9699188 
* Add V1 of the about template
* Add routing to preview theme pages outside of website builder
* Make theme pages only available after auth
adarsh
adarsh approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@adarsh adarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would consider adding some info about themes to the documentation .md files in this repo. Tests would be great also but not required.

app/decorators/staff/theme_decorator.rb
# helpers.content_tag :span, class: 'time' do
# object.created_at.strftime("%a %m/%d/%y")
# end
# end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyjamesbrooks codyjamesbrooks Awaiting requested review from codyjamesbrooks

1 more reviewer

@adarsh adarsh adarsh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devonharless @adarsh