-
Notifications
You must be signed in to change notification settings - Fork 12
Upgrade to Rails 8.1 beta #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| gem 'sprockets-rails', '~> 3.2.2' | ||
| gem "activerecord-trilogy-adapter" # for mysql installation | ||
| gem 'trilogy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't this already in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think trilogy was indirectly loaded as a dependency for activerecord-trilogy-adapter. That is no longer needed as of rails 7.1+, so I added just the trilogy adapter.
maebeale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦾 wtg!!!
220133f to
3727b50
Compare
3727b50 to
6624e51
Compare
What is the goal of this PR and why is this important?
We are upgrading to rails 8.1.beta1 to bring the framework up to date.
How did you approach the change?
I upgraded to rails 7.0, 7.1, 7.2 and 8.0 and made sure the tests were passing and the app looked good for users and admins.
Running everything in docker containers.
Anything else to add?
We want to try this in staging to make sure it works well outside of the dev containers.
Thanks @johnpaulashenfelter for the commits and helping with the upgrade!