Skip to content

Conversation

@marc
Copy link
Collaborator

@marc marc commented Sep 13, 2025

What is the goal of this PR and why is this important?

We are upgrading to rails 8.1.beta1 to bring the framework up to date.

How did you approach the change?

I upgraded to rails 7.0, 7.1, 7.2 and 8.0 and made sure the tests were passing and the app looked good for users and admins.
Running everything in docker containers.

Anything else to add?

We want to try this in staging to make sure it works well outside of the dev containers.
Thanks @johnpaulashenfelter for the commits and helping with the upgrade!

@marc marc added this to AWBW Sep 13, 2025
@marc marc marked this pull request as ready for review September 13, 2025 18:08

gem 'sprockets-rails', '~> 3.2.2'
gem "activerecord-trilogy-adapter" # for mysql installation
gem 'trilogy'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't this already in there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think trilogy was indirectly loaded as a dependency for activerecord-trilogy-adapter. That is no longer needed as of rails 7.1+, so I added just the trilogy adapter.

Copy link
Collaborator

@maebeale maebeale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾 wtg!!!

@elasticspoon elasticspoon force-pushed the feature/rails81beta branch 3 times, most recently from 220133f to 3727b50 Compare September 13, 2025 19:51
@elasticspoon elasticspoon merged commit c89fcbf into main Sep 13, 2025
2 checks passed
@elasticspoon elasticspoon deleted the feature/rails81beta branch September 13, 2025 19:57
@github-project-automation github-project-automation bot moved this to Done in AWBW Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants