Skip to content

Add resource crud #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maebeale merged 5 commits into from
Sep 13, 2025
Merged

Add resource crud #147

maebeale merged 5 commits into from
Sep 13, 2025

Conversation

@maebeale
Copy link
Collaborator

@maebeale maebeale commented Sep 13, 2025

  • This work is part of [link an issue]

What is the goal of this PR and why is this important?

  • make CRUD available outside RailsAdmin

How did you approach the change?

  • moved list of resource kinds out of controller method and in to constant in the model
  • trim down the form from fields and associations that were used from outset
  • change factory to only required fields
  • change default of 'inactive' to false via the model
  • change search functionality per user for use on resources index

Anything else to add?

  • there was conditional logic around when a resource was of type == 'Scholarship', but stakeholders report they don't use this system for scholarships, so that was removed
  • i've chosen to leave the legacy fields in the database, but just not exposing them in the forms

@maebeale
Replace hard-coded controller method with constant in Resource for 'K…
ed92bad 
…INDS'
@maebeale
Remove helper methods that generate form data no longer needed outsid…
d3eaf5e 
…e RailsAdmin
@maebeale
Remove Resources from ActiveAdmin routes (and don't have it listed tw…
6f13b1a 
…ice)
@maebeale
Resource CRUD
8e049bb 
- make CRUD available outside RailsAdmin
- trim down the factory to only required fields
- change default of 'inactive' to false
- change search functionality per user for use on resources index
@maebeale
Merge conflicts in routes and model
674669c
@maebeale maebeale merged commit c2f7b0d into main Sep 13, 2025
2 checks passed
@maebeale maebeale deleted the add-resource-crud branch September 13, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elasticspoon elasticspoon Awaiting requested review from elasticspoon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maebeale