Skip to content

Conversation

@caseyvaughn
Copy link
Collaborator

@caseyvaughn caseyvaughn commented Aug 14, 2025

What is the goal of this PR and why is this important?

  • Upgrade to Rails 6.1

How did you approach the change?

  • Upgrade to Rails 6.1, run test suite to find breaking changes
  • Updated how enums are defined (in Rails 6.1 enum values must be symbols/strings without spaces/special characters

Anything else to add?

  • added xit to mailer specs that were already failing before this upgrade for ease of testing breaking changes from this upgrade
  • the change to the enums in form_field will require more changes to in form_field where answer_type and answer_data_type are used. I'm thinking of addressing those refactors in a separate PR, but I can address them here if that's preferred

@caseyvaughn caseyvaughn marked this pull request as ready for review August 18, 2025 20:55
@seanmarcia seanmarcia merged commit b19aeb5 into main Aug 20, 2025
1 check passed
@caseyvaughn caseyvaughn mentioned this pull request Aug 20, 2025
@johnpaulashenfelter johnpaulashenfelter deleted the upgrade-rails-6.1 branch September 12, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants