Skip to content

Set owner type on workshop log to workshop #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maebeale merged 2 commits into from
Dec 2, 2025
Merged

Set owner type on workshop log to workshop #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb44bb
Remove validation on workshop from story idea (bc sometimes enter ext…
maebeale Dec 2, 2025
0522b10
Set owner_type to Workshop if workshop_id present on workshop_log
maebeale Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/models/story_idea.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ class StoryIdea < ApplicationRecord
validates :updated_by_id, presence: true
validates :project_id, presence: true
validates :windows_type_id, presence: true
validates :workshop_id, presence: true
validates :body, presence: true
validates :permission_given, presence: true
validates :publish_preferences, presence: true
Expand Down
1 change: 1 addition & 0 deletions app/models/workshop_log.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ def update_owner_and_date
changes = {}
changes[:date] = created_at if date.blank?
changes[:owner_id] = workshop_id if owner_id.blank?
changes[:owner_type] = "Workshop" if workshop_id
update_columns(changes) if changes.any?
end

Expand Down