Add blur on submit to collection controller #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add class to resource results add class to workshop results
maebeale
reviewed
Jan 4, 2026
| // Connects to data-controller="collection" | ||
| export default class extends Controller { | ||
| static classes = [ "unselected", "selected" ] | ||
| static classes = ["unselected", "selected"]; |
Collaborator
There was a problem hiding this comment.
don't you still need to add the spaces around the brackets, per rubocop?
Collaborator
Author
There was a problem hiding this comment.
rubocop is only for Ruby. I added "Prettier" recently to handle my JS files for the time being.
maebeale
approved these changes
Jan 4, 2026
Collaborator
maebeale
left a comment
maebeale
left a comment
There was a problem hiding this comment.
Love this improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
'Workshops and Resources have search results updated "on click" or while typing. This PR provides visual indication the request has been submitted. Prior, a slow query could feel as though nothing was happening when a user selected a filter.
How did you approach the change?
Update collection stimulus controller to add the tailwind class "blur-sm" to targeted elements. Add the class "blur-on-submit" to any element that should be blurred on user inputs.
Anything else to add?
screenrecording-2026-01-02_10-42-34.mp4