-
Notifications
You must be signed in to change notification settings - Fork 12
Add dependency auditing to AWBW #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency auditing to AWBW #76
Conversation
Adds dependency auditing using GitHub's dependabot Based on the Homeward Tails implementation here https://github.com/rubyforgood/homeward-tails/blob/main/.github/dependabot.yml with the interval initially set to weekly to test the workflow. If we are comfortable with a more frequent upgrade schedule, the configuration can be changed to daily.
|
I left this comment on the issue but ill duplicate it here: This is great! Dependabot is probably the best approach but I would say this should wait until we get the app to rails 8. So many of the dependencies are out of date that if dependabot starts opening PR it's gonna create a crazy amount of noise. Some other notes too:
|
fwiw, I agree with @elasticspoon re waiting until we've done some more of the upgrade work. AND, very excited to get this added to this project -- thanks, @lenikadali! |
Makes sense. Will add 👌
No worries 😎 I think we can discuss this in the Upgrade and Stuff to Do #3 issue |
|
Partially handled in #110. Can add Rails after upgrades are over to reduce the noise. |
Merged main branch as it contains PR rubyforgood#110 rubyforgood#110 that completes the addition of dependency audits to AWBW with the exception of Rails.
Nice! 😇 In which workflow should I put the
@elasticspoon for now, I think I will put a |
maebeale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree we can start weekly and go from there. Thanks for getting this into the project, @lenikadali !
Added a TODO for adding group updates to dependabot in the dependabot workflow so that it doesn't get forgotten since we are not sure how grouping will fit with the current structure of the workflows.
What is the goal of this PR and why is this important?
Adding dependency auditing using GitHub's dependabot
How did you approach the change?
Looked at the Homeward Tails implementation here and the Dependabot documentation here with the interval initially set to weekly to test the workflow. If we are comfortable with a more frequent upgrade schedule, the configuration can be changed to daily.
Anything else to add?
Maybe we want to use renovate? My impression is that is meant for non-GitHub repositories (e.g. it would be useful if we were on GitLab or Codeberg) but happy to use that if it fits 😊
P.S: We can merge and do a test run. If it doesn't work the way we would like, then we can revert the change and/or push up a fix for the workflow.