feat: add shopify rubocop #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maebeale
reviewed
Sep 11, 2025
|
|
||
| def project_workshop_logs(date, windows_type, project_id) | ||
| if project_id | ||
| if project_id |
Collaborator
There was a problem hiding this comment.
not sure why this got indented, but ok
|
This pull request has been inactive for 30 days. Please update it or let us know if it is still relevant. |
1 similar comment
|
This pull request has been inactive for 30 days. Please update it or let us know if it is still relevant. |
Collaborator
|
@elasticspoon what was wrong w this PR? (asking bc we want a linter to complete the CI updates) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shopify rubocop with various applicable plugins
Some stuff needs fixing but for now I added inline todos for those