Merge pull request #6531 from AudTheCodeWitch/acook/6321/update-judges-new-spec

System Test Overhaul spec/system/judges/new_spec.rb

Author: compwron

spec/system/judges/new_spec.rb

@@ -1,25 +1,87 @@
+# frozen_string_literal: true
+
 require "rails_helper"
+require "faker"
 
 RSpec.describe "judges/new", type: :system do
   let(:organization) { create(:casa_org) }
   let(:admin) { create(:casa_admin, casa_org_id: organization.id) }
+  let(:active_name) { Faker::Name.unique.name }
+  let(:inactive_name) { Faker::Name.unique.name }
 
   before do
     sign_in admin
-
     visit new_judge_path
   end
 
-  it "adds new judge" do
-    fill_in "Name", with: ""
-    click_on "Submit"
+  # rubocop:disable RSpec/ExampleLength
+  it "creates an active judge with valid name", :aggregate_failures do
+    submit_judge_form(name: active_name, active: true)
+    expect(page).to have_text("Judge was successfully created.")
+    expect(page).to have_text(active_name)
 
-    expect(page).to have_text("Name can't be blank")
+    judge = Judge.find_by(name: active_name)
+    expect(judge).not_to be_nil
+    expect(judge.active).to be true
+  end
+  # rubocop:enable RSpec/ExampleLength
 
-    fill_in "Name", with: "Joey Shmoey"
-    click_on "Submit"
+  # rubocop:disable RSpec/ExampleLength
+  it "creates an inactive judge with valid name", :aggregate_failures do
+    submit_judge_form(name: inactive_name, active: false)
+    expect(page).to have_text("Judge was successfully created.")
+    expect(page).to have_text(inactive_name)
+
+    judge = Judge.find_by(name: inactive_name)
+    expect(judge).not_to be_nil
+    expect(judge.active).to be false
+  end
+  # rubocop:enable RSpec/ExampleLength
 
+  # rubocop:disable RSpec/ExampleLength
+  it "creates a judge with a very long name", :aggregate_failures do
+    long_name = Faker::Lorem.characters(number: 255)
+    submit_judge_form(name: long_name)
     expect(page).to have_text("Judge was successfully created.")
-    expect(page).to have_text("Joey Shmoey")
+    expect(page).to have_text(long_name)
+
+    judge = Judge.find_by(name: long_name)
+    expect(judge).not_to be_nil
+  end
+  # rubocop:enable RSpec/ExampleLength
+
+  # rubocop:disable RSpec/ExampleLength
+  it "creates a judge with special characters in the name", :aggregate_failures do
+    special_name = "#{Faker::Lorem.characters(number: 30, min_alpha: 10, min_numeric: 5)}!@#$%^&*()"
+    submit_judge_form(name: special_name)
+    expect(page).to have_text("Judge was successfully created.")
+    expect(page).to have_text(special_name)
+
+    judge = Judge.find_by(name: special_name)
+    expect(judge).not_to be_nil
+  end
+  # rubocop:enable RSpec/ExampleLength
+
+  context "when validations fail" do
+    it "shows validation error when name is blank" do
+      submit_judge_form(name: "")
+      expect(page).to have_text("Name can't be blank")
+    end
+
+    it "does not allow duplicate judge names in the same organization", :aggregate_failures do
+      duplicate_name = Faker::Name.unique.name
+      create(:judge, name: duplicate_name, casa_org: organization)
+      submit_judge_form(name: duplicate_name)
+      expect(page).to have_text("Name has already been taken")
+      expect(Judge.where(name: duplicate_name, casa_org: organization).count).to eq 1
+    end
+  end
+
+  private
+
+  def submit_judge_form(name:, active: true)
+    fill_in "Name", with: name
+    active ? check("Active?") : uncheck("Active?")
+    click_on "Submit"
   end
 end