remove some warning

ran rspec with --warnings flag and fixed most of them in our code

Author: thejonroberts

app/services/followup_service.rb

@@ -16,9 +16,7 @@ def self.create_followup(case_contact, creator, note)
     followup
   end
 
-  private_class_method
-
-  def self.send_notification(followup, creator)
+  private_class_method def self.send_notification(followup, creator)
     FollowupNotifier
       .with(followup: followup, created_by: creator)
       .deliver(followup.case_contact.creator)

app/views/case_contacts/form/details.html.erb

@@ -54,7 +54,6 @@
           </h3>
           <% min_date = CaseContact::MINIMUM_DATE %>
           <% current_date = Time.zone.today %>
-          <% initial_value = @case_contact.occurred_at&.to_date %>
           <%= form.date_field(:occurred_at,
             required: true,
             max: (current_date + 1.day).to_fs(:iso8601),

spec/services/placement_export_csv_service_spec.rb

@@ -6,7 +6,7 @@
     casa_org = create(:casa_org, name: "Fake Name", display_name: "Fake Display Name")
     placement_type = create(:placement_type, casa_org: casa_org)
     creator = create(:user)
-    placement = create(:placement, creator: creator, placement_type: placement_type) # rubocop:disable Lint/UselessAssignment
+    create(:placement, creator: creator, placement_type: placement_type)
 
     csv_headers = "Casa Org,Casa Case Number,Placement Type,Placement Started At,Created At,Creator Name\n"
     result = PlacementExportCsvService.new(casa_org: casa_org).perform

spec/support/capybara.rb

@@ -15,14 +15,7 @@
 Capybara.disable_animation = true
 
 Capybara::Screenshot.autosave_on_failure = true
-
-module Capybara
-  module Screenshot
-    def self.capybara_tmp_path
-      Rails.root.join("tmp", "screenshots#{ENV["GROUPS_UNDERSCORE"]}")
-    end
-  end
-end
+Capybara.save_path = Rails.root.join("tmp", "screenshots#{ENV["GROUPS_UNDERSCORE"]}")
 
 options = Selenium::WebDriver::Chrome::Options.new
 options.add_argument("--disable-gpu")

spec/support/pretender_context.rb

@@ -0,0 +1,4 @@
+module PretenderContext
+  def true_user
+  end
+end

spec/views/layouts/header.html.erb_spec.rb

@@ -1,10 +1,5 @@
 require "rails_helper"
 
-module PretenderContext
-  def true_user
-  end
-end
-
 RSpec.describe "layout/header", type: :view do
   before do
     view.class.include PretenderContext

spec/views/layouts/sidebar.html.erb_spec.rb

@@ -1,10 +1,5 @@
 require "rails_helper"
 
-module PretenderContext
-  def true_user
-  end
-end
-
 RSpec.describe "layout/sidebar", type: :view do
   before do
     view.class.include PretenderContext