Feature/email validate message#6150
Merged
compwron merged 4 commits intorubyforgood:mainfrom Jan 3, 2025
Merged
Conversation
Raushan998
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
Raushan998
force-pushed
the
feature/email_validate_message
branch
2 times, most recently
from
e948a5e to
9af2583
Compare
github-actions
bot
added
the
dependencies
Raushan998
force-pushed
the
feature/email_validate_message
branch
from
9af2583 to
e948a5e
Compare
Collaborator
|
Lots of failing tests |
Collaborator
|
Probably a test factory issue? |
Author
|
@compwron actually earlier validation has been setup at database layer but now it has been changed to application layer that's the reason for failing specs. |
Collaborator
|
Please fix the specs :) |
Raushan998
force-pushed
the
feature/email_validate_message
branch
from
e948a5e to
9b413a2
Compare
Author
|
done :) |
compwron
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves issue #6147
What changed, and why?
Validation for email message has been changed. It has been changed so that validation of email message should be more relevant to user who is creating it.
How is this tested? (please write tests!) 💖💪
It has been tested through writing the unit test using rspec.
💪
Feelings gif (optional)