Add Placement Types management functionality#6491
Merged
compwron merged 7 commits intorfg-event-2025from Sep 26, 2025
Merged
Conversation
abachman
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
bot
added
ruby
- Introduced PlacementTypesController with actions for new, create, edit, and update. - Added routes for placement types. - Implemented views for managing placement types. - Created policies to manage access to placement types. - Added tests for placement types functionality in both request and policy specs. fixes #5778
abachman
force-pushed
the
abachman/edit-org-placement-types
branch
from
336eabb to
4f53c7b
Compare
Collaborator
|
The Rubocop changes here all work great for me, and they seem to prevent the problems I was struggling with yesterday |
h-m-m
reviewed
Sep 13, 2025
h-m-m
reviewed
Sep 13, 2025
gvt
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5778, which will resolve #4695.
What changed, and why?
Added control of PlacementType records for organization admins via the existing /casa_org/:id/edit page / flow.
Admins can create new and update existing placement types belonging to their organization.
Additional Changes
.rubocop.ymlto prevent errors caused by the rubocop + standard upgrades in Streamline capybara matchers for system/supervisors/index_spec #6488bundle exec erblinttobundle exec erb_lintin response to a deprecation wraningHow is this tested? (please write rspec and jest tests!) 💖💪
Screenshots
Placement Types listed on
/casa_org/:id/edit:Editing an existing Placement Type form:
Creating a new Placement Type form:
Feelings gif (optional)