CasaCasesEmancipationOption rename to follow naming convention#6709
Merged
FireLemons merged 4 commits intorubyforgood:mainfrom Feb 13, 2026
Merged
Conversation
compwron
reviewed
Feb 13, 2026
Collaborator
compwron
left a comment
There was a problem hiding this comment.
At work I would call this too dangerous and insist it be 4 separate PRs for new table, updating call sites to double write, and backfill, then full swapover
But... we have db backups... probably fine tbh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6707
What changed, and why?
The model class CasaCasesEmancipationOption has casa cases in plural which doesn't follow the naming convention of join tables.
The class name was renamed to CasaCaseEmancipationOption
How is this tested? (please write rspec and jest tests!) 💖💪
Tried the migrations locally. Rest of it should be caught by CI.