Merge pull request #5429 from janeewheatley/fix-vendor-purchase-sorting-5428

5428 Sort vendor purchases by issued_at in reverse chronological order

Author: ruestitch

app/controllers/vendors_controller.rb

@@ -47,6 +47,7 @@ def edit
 
   def show
     @vendor = current_organization.vendors.includes(:purchases).find(params[:id])
+    @purchases = @vendor.purchases.order(issued_at: :desc)
   end
 
   def update

app/views/vendors/show.html.erb

@@ -74,9 +74,9 @@
               </tr>
               </thead>
               <tbody>
-              <% @vendor.purchases.each do |purchase| %>
+              <% @purchases.each do |purchase| %>
                 <tr>
-                  <td><%= purchase.created_at.strftime("%m/%d/%Y") %></td>
+                  <td><%= purchase.issued_at.strftime("%m/%d/%Y") %></td>
                   <td><%= purchase.line_items.total %></td>
                   <td><%= view_button_to purchase, { text: "View purchase details" } %></td>
                 </tr>

spec/requests/vendors_requests_spec.rb

@@ -123,6 +123,27 @@
         get vendor_path(id: create(:vendor, organization: organization))
         expect(response).to be_successful
       end
+
+      it "displays purchases in reverse chronological order by issued_at date" do
+        vendor = create(:vendor, organization: organization)
+
+        # Create purchases with different issued_at dates
+        old_purchase = create(:purchase, vendor: vendor, issued_at: 1.week.ago, organization: organization)
+        new_purchase = create(:purchase, vendor: vendor, issued_at: 1.day.ago, organization: organization)
+        middle_purchase = create(:purchase, vendor: vendor, issued_at: 3.days.ago, organization: organization)
+
+        get vendor_path(vendor)
+
+        old_date = old_purchase.issued_at.strftime("%m/%d/%Y")
+        middle_date = middle_purchase.issued_at.strftime("%m/%d/%Y")
+        new_date = new_purchase.issued_at.strftime("%m/%d/%Y")
+
+        dates = [new_date, middle_date, old_date]
+        dates.each { |date| expect(response.body).to include(date) }
+
+        expect(response.body.index(new_date)).to be < response.body.index(middle_date)
+        expect(response.body.index(middle_date)).to be < response.body.index(old_date)
+      end
     end
 
     describe "DELETE #destroy" do