Remove other mentions of organization.short_name

Author: jp524

app/controllers/admin/organizations_controller.rb

@@ -86,7 +86,7 @@ def destroy
 
   def organization_params
     params.require(:organization)
-          .permit(:name, :short_name, :street, :city, :state, :zipcode, :email, :url, :logo, :intake_location, :default_email_text, :account_request_id, :reminder_day, :deadline_day,
+          .permit(:name, :street, :city, :state, :zipcode, :email, :url, :logo, :intake_location, :default_email_text, :account_request_id, :reminder_day, :deadline_day,
                   users_attributes: %i(name email organization_admin), account_request_attributes: %i(ndbn_member_id id))
   end
 

app/controllers/historical_trends/base_controller.rb

@@ -1,5 +1,5 @@
 class HistoricalTrends::BaseController < ApplicationController
   def cached_series(type)
-    Rails.cache.fetch("#{current_organization.short_name}-historical-#{type}-data") { HistoricalTrendService.new(current_organization.id, type).series }
+    Rails.cache.fetch("#{current_organization.id}-historical-#{type}-data") { HistoricalTrendService.new(current_organization.id, type).series }
   end
 end

app/controllers/organizations_controller.rb

@@ -92,7 +92,7 @@ def organization_params
     request_type_formatter(params)
 
     params.require(:organization).permit(
-      :name, :short_name, :street, :city, :state,
+      :name, :street, :city, :state,
       :zipcode, :email, :url, :logo, :intake_location,
       :default_storage_location, :default_email_text, :reminder_email_text,
       :invitation_text, :reminder_day, :deadline_day,

app/jobs/historical_data_cache_job.rb

@@ -2,7 +2,7 @@ class HistoricalDataCacheJob < ApplicationJob
   def perform(org_id:, type:)
     organization = Organization.find_by(id: org_id)
 
-    Rails.cache.write("#{organization.short_name}-historical-#{type}-data", HistoricalTrendService.new(organization.id, type).series)
+    Rails.cache.write("#{organization.id}-historical-#{type}-data", HistoricalTrendService.new(organization.id, type).series)
   end
 
   def queue_name = "low_priority"

app/services/distribution_service.rb

@@ -10,10 +10,10 @@ def perform_distribution_service(&block)
     set_error(e)
   rescue Errors::InsufficientAllotment => e
     distribution.line_items.assign_insufficiency_errors(e.insufficient_items)
-    Rails.logger.error "[!] #{self.class.name} failed because of Insufficient Allotment #{distribution_organization.short_name}: #{distribution.errors.full_messages} [#{e.message}]"
+    Rails.logger.error "[!] #{self.class.name} failed because of Insufficient Allotment #{distribution_organization.name}: #{distribution.errors.full_messages} [#{e.message}]"
     set_error(e)
   rescue StandardError => e
-    Rails.logger.error "[!] #{self.class.name} failed for #{distribution_organization.short_name}: #{distribution.errors.full_messages} [#{e.inspect}]"
+    Rails.logger.error "[!] #{self.class.name} failed for #{distribution_organization.name}: #{distribution.errors.full_messages} [#{e.inspect}]"
     set_error(e)
   ensure
     return self

lib/test_helpers/pdf_comparison_test_factory.rb

@@ -13,7 +13,6 @@ def self.get_logo_file
   def self.create_organization_storage_items(logo = get_logo_file)
     org = Organization.create!(
       name: "Essentials Bank 1",
-      short_name: "db",
       street: "1500 Remount Road",
       city: "Front Royal",
       state: "VA",

spec/factories/organizations.rb

@@ -44,7 +44,6 @@
     end
 
     sequence(:name) { |n| "Essentials Bank #{n}" } # 037000863427
-    sequence(:short_name) { |n| "db_#{n}" } # 037000863427
     sequence(:email) { |n| "email#{n}@example.com" } # 037000863427
     sequence(:url) { |n| "https://organization#{n}.org" } # 037000863427
     street { "1500 Remount Road" }

spec/jobs/historical_data_cache_job_spec.rb

@@ -17,7 +17,7 @@
 
     perform_enqueued_jobs { job }
 
-    cached_data = Rails.cache.read("#{organization.short_name}-historical-#{type}-data")
+    cached_data = Rails.cache.read("#{organization.id}-historical-#{type}-data")
     expect(cached_data).to eq(expected_data)
   end
 end

spec/requests/items_requests_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe "Items", type: :request do
-  let(:organization) { create(:organization, short_name: "my_org") }
+  let(:organization) { create(:organization) }
   let(:user) { create(:user, organization: organization) }
 
   describe "while signed in" do