Prevent deletion of items that are part of a request (#4734)

Author: jorgecoutinhobr

app/models/item.rb

@@ -135,6 +135,10 @@ def has_inventory?(inventory = nil)
     end
   end
 
+  def in_request?
+    Request.by_request_item_id(id).exists?
+  end
+
   def is_in_kit?(kits = nil)
     if kits
       kits.any? { |k| k.line_items.map(&:item_id).include?(id) }
@@ -147,7 +151,7 @@ def is_in_kit?(kits = nil)
   end
 
   def can_delete?(inventory = nil, kits = nil)
-    can_deactivate_or_delete?(inventory, kits) && line_items.none? && !barcode_count&.positive?
+    can_deactivate_or_delete?(inventory, kits) && line_items.none? && !barcode_count&.positive? && !in_request?
   end
 
   # @return [Boolean]

spec/models/item_spec.rb

@@ -312,6 +312,16 @@
           expect(item.can_delete?).to eq(false)
         end
       end
+
+      context "in a request" do
+        before do
+          create(:request, request_items: [{"item_id" => item.id, "quantity" => 5}])
+        end
+
+        it "should return false" do
+          expect(item.can_delete?).to eq(false)
+        end
+      end
     end
 
     describe '#deactivate!' do