Skip to content

Fix topics seeds and eager loading #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmitrytrager merged 3 commits into from
Apr 16, 2025
Merged

Fix topics seeds and eager loading #144

dmitrytrager merged 3 commits into from
Apr 16, 2025

Conversation

@hernanvicente
Copy link
Collaborator

@hernanvicente hernanvicente commented Apr 12, 2025 •
edited
Loading

What Issue Does This PR Cover, If Any?

  • DB seeds are failing
  • Bullet reports an eager loading of providers on topics

Resolves #143

What Changed? And Why Did It Change?

  • The topic seeds were updated
  • The topics controller scope includes providers

Please Provide Screenshots

Before
Screenshot 2025-04-12 at 11 48 39

After
Screenshot 2025-04-12 at 11 50 39

Before
Screenshot 2025-04-12 at 11 52 21

After
Screenshot 2025-04-12 at 11 53 29

@hernanvicente hernanvicente linked an issue Apr 12, 2025 that may be closed by this pull request
Fix seeds and eager loading on topics #143
Closed
@hernanvicente hernanvicente self-assigned this Apr 12, 2025
@hernanvicente hernanvicente added the bug Something isn't working label Apr 12, 2025
dmitrytrager
dmitrytrager reviewed Apr 12, 2025
View reviewed changes
app/controllers/topics_controller.rb Outdated
else
Current.user.topics
end.includes(:language)
end.includes(:language, :provider)
Copy link
Collaborator

@dmitrytrager dmitrytrager Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

While using this branch, I can see the following:
Screenshot 2025-04-12 at 14 35 42

Copy link
Collaborator Author

@hernanvicente hernanvicente Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitrytrager Thanks for pointing out my oversight 🙈

@hernanvicente hernanvicente force-pushed the 143-fix-seeds-and-eager-loading-on-topics branch from 2619ad1 to c8d7925 Compare April 14, 2025 08:29
@dmitrytrager dmitrytrager merged commit a6f592a into main Apr 16, 2025
4 checks passed
@dmitrytrager dmitrytrager deleted the 143-fix-seeds-and-eager-loading-on-topics branch April 16, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitrytrager dmitrytrager dmitrytrager approved these changes

@dcollie2 dcollie2 Awaiting requested review from dcollie2

@Dalyl09 Dalyl09 Awaiting requested review from Dalyl09

Assignees

@hernanvicente hernanvicente

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix seeds and eager loading on topics

3 participants

@hernanvicente @dmitrytrager