Skip to content

Conversation

@hernanvicente
Copy link
Collaborator

@hernanvicente hernanvicente commented Jun 26, 2025

What Issue Does This PR Cover, If Any?

Resolves #216

What Changed?

  • ImportReport and ImportError models created
  • The Import Reports area shows the importing errors

And Why Did It Change?

We want to keep an eye on and track how our import files script works; therefore, we created some temporary models, and we are reusing the admin area to present the saved import error records.

How Has This Been Tested?

Manually, no specs :(

Please Provide Screenshots

Screenshot 2025-06-28 at 16 15 23 Screenshot 2025-06-28 at 16 15 03

Additional Comments

Run DataImport.reset from the Rails Console and wait

@hernanvicente hernanvicente linked an issue Jun 26, 2025 that may be closed by this pull request
@hernanvicente hernanvicente changed the title feat: add import report and errors models #216 Import report Jun 26, 2025
@hernanvicente hernanvicente force-pushed the 216-save-and-report-import-errors branch 3 times, most recently from 827adc4 to 9ea1b10 Compare June 26, 2025 19:51
hernanvicente added a commit that referenced this pull request Jun 27, 2025
@hernanvicente hernanvicente self-assigned this Jun 27, 2025
hernanvicente added a commit that referenced this pull request Jun 27, 2025
@hernanvicente hernanvicente force-pushed the 216-save-and-report-import-errors branch 4 times, most recently from 0b2c4a6 to e27a586 Compare June 28, 2025 14:17
@hernanvicente hernanvicente marked this pull request as ready for review June 28, 2025 14:18
@hernanvicente hernanvicente requested review from Oli0li and dcollie2 June 28, 2025 14:18
@hernanvicente hernanvicente force-pushed the 216-save-and-report-import-errors branch from e27a586 to f51bf59 Compare June 29, 2025 10:00
end

def self.filter_rows_with_existing_topics(csv_data, stats)
def self.filter_rows_with_existing_topics(csv_data, stats, report)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove report from params?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@dcollie2 dcollie2 merged commit 4df5137 into main Jul 1, 2025
4 checks passed
@dcollie2 dcollie2 deleted the 216-save-and-report-import-errors branch July 1, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save and report import errors

3 participants