-
Notifications
You must be signed in to change notification settings - Fork 6
Import report #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Import report #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
827adc4 to
9ea1b10
Compare
0b2c4a6 to
e27a586
Compare
e27a586 to
f51bf59
Compare
dcollie2
approved these changes
Jul 1, 2025
lib/autorequire/data_import.rb
Outdated
| end | ||
|
|
||
| def self.filter_rows_with_existing_topics(csv_data, stats) | ||
| def self.filter_rows_with_existing_topics(csv_data, stats, report) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove report from params?
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

What Issue Does This PR Cover, If Any?
Resolves #216
What Changed?
And Why Did It Change?
We want to keep an eye on and track how our import files script works; therefore, we created some temporary models, and we are reusing the admin area to present the saved import error records.
How Has This Been Tested?
Manually, no specs :(
Please Provide Screenshots
Additional Comments
Run
DataImport.resetfrom the Rails Console and wait