Add Rails 8 authentication #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Remember me" seems to be already handled by Authentication#start_new_session_for(user), which creates a permanent cookie for the user.
Oli0li
force-pushed
the
epic-1-add-authentication
branch
from
ac95cdc to
c18e315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves #8
What Changed? And Why Did It Change?
For now these are just the basic views with no styling.
The "Remember me" functonality seems to be already handled by Authentication#start_new_session_for(user), which creates a permanent cookie for the use when signing in a user.
We will need to add this on controllers for which authentication is required:
before_action :resume_session, only: [:index]How Has This Been Tested?
We tested this manually.
We will write tests once RSpec has been added to the project.
Please Provide Screenshots
Additional Comments
The User model will need a provider_id once the Providers table has been created. It will also need special validations for Admins.