Language model 16 #38
Conversation
* main: remove maily update authentication helpers for tests update Readme add maily, letter_opener and bullet
Gemfile
Outdated
| gem "stimulus-rails" | ||
| # Build JSON APIs with ease [https://github.com/rails/jbuilder] | ||
| gem "jbuilder" | ||
| gem "slim-rails" |
There was a problem hiding this comment.
I don't think we should add this gem -- It adds additional complexity for new people/designers.
There was a problem hiding this comment.
This gem does not disable using erb for us
There was a problem hiding this comment.
I know but having slim in the app makes it harder for newbies to contribute since they may not be familiar with slim/haml syntax.
There was a problem hiding this comment.
Maybe we could add some words into Readme saying that people can use what they best contribute with?
There was a problem hiding this comment.
I agree with not adding more complexity. We should keep just one template DSL or format; it will avoid confusion or divergent styles for later markup implementations.
There was a problem hiding this comment.
My idea was that there is no complexity in CRUD application markup which Skillrx really is.
At the same time Erb template can be twice bigger and that makes things a bit slow.
There was a problem hiding this comment.
@seanmarcia @hernanvicente I've removed slim
dmitrytrager
force-pushed
the
language-model-16
branch
from
24eb554 to
2bb0dac
Compare
db/structure.sql
Outdated
| @@ -0,0 +1,276 @@ | |||
| SET statement_timeout = 0; | |||
There was a problem hiding this comment.
We also shouldn't move away from a schema.rb unless we absolutely have to.
There was a problem hiding this comment.
Reverted this change as well
This reverts commit 19cec14.
dmitrytrager
force-pushed
the
language-model-16
branch
from
ea777f2 to
3ca5b16
Compare
seanmarcia
left a comment
seanmarcia
left a comment
There was a problem hiding this comment.
Can you rebase main in? Other than that it is good to go.
* main: Provider model implementation (#43)
What Issue Does This PR Cover, If Any?
Resolves #16
What Changed? And Why Did It Change?
Added model, seeds, migration, controller, views and tests to work with controllers
How Has This Been Tested?
With rspec request tests
Please Provide Screenshots
Additional Comments
I've also introduced slim and rewrote some views to make them more verbose.
Though didn't add any language folder configuration for file storage