Skip to content

Conversation

@hernanvicente
Copy link
Collaborator

@hernanvicente hernanvicente commented Feb 4, 2025

What Issue Does This PR Cover, If Any?

Resolves #21

What Changed? And Why Did It Change?

  • Add tags to functionality using the acts-as-taggable-on gem
  • Add tags for topics
  • Tags with languages are implemented relying on the dynamic contexts
  • The UI functionality(autocomplete + badges) is implemented through a Stimulus controller and the bootstrap5-tags was introduced.

How Has This Been Tested?

  • Tests are in place

Please Provide Screenshots

Screen Shot 2025-03-15 at 18 30 58

Screen Shot 2025-03-15 at 18 18 56

@hernanvicente hernanvicente linked an issue Feb 4, 2025 that may be closed by this pull request
7 tasks
@hernanvicente hernanvicente force-pushed the 21-base-tagging-implementation branch from 9d3b30d to d8028b0 Compare February 4, 2025 10:57
@hernanvicente hernanvicente force-pushed the 21-base-tagging-implementation branch 3 times, most recently from 1ad7a2b to 5b91cbc Compare March 1, 2025 14:57
@hernanvicente hernanvicente force-pushed the 21-base-tagging-implementation branch 3 times, most recently from f6d2e3f to 172ad05 Compare March 7, 2025 12:22
@hernanvicente hernanvicente force-pushed the 21-base-tagging-implementation branch from 8ff9b3e to 88ca250 Compare March 15, 2025 17:04
@hernanvicente hernanvicente marked this pull request as ready for review March 15, 2025 17:38
@hernanvicente hernanvicente changed the title Add acts-as-taggable-on gem for tagging functionality Add tagging functionality Mar 15, 2025
@hernanvicente hernanvicente changed the title Add tagging functionality Add tagging functionality for topics Mar 15, 2025
@hernanvicente hernanvicente force-pushed the 21-base-tagging-implementation branch 2 times, most recently from b392f09 to 3668b6d Compare March 15, 2025 19:06
@dcollie2
Copy link
Collaborator

I have not had time to fully diagnose, but when I run this locally I am losing the language context for the tags. I'll try to look into it further tonight.

Copy link
Collaborator

@Oli0li Oli0li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hernanvicente for doing this, I've never used that gem for tags so it's interesting to see how it works! I just left a couple of small comments

@dcollie2
Copy link
Collaborator

I'm having some troubles with this and I'm not sure if they're local to me or if the scope you're covering is different from what I'm expecting. Basically, adding a tag that doesn't exist is not working. If tags already exist for a language, I can add them using the select box but I cannot create a new tag for that language or for a language without tags.

Screenshot 2025-03-17 at 5 47 57 PM

Screenshot 2025-03-17 at 5 48 20 PM

@hernanvicente
Copy link
Collaborator Author

Hello @dcollie2, to add new tags, the user must press ENTER. Maybe this necessary action isn't obvious or intuitive enough, so I added a hint (right to the label). Here is a short video. Let me know if you have further questions.

topics_tags.mp4

@hernanvicente hernanvicente force-pushed the 21-base-tagging-implementation branch from f56a5ab to 863b4e1 Compare March 22, 2025 09:47
@dcollie2
Copy link
Collaborator

Hello @dcollie2, to add new tags, the user must press ENTER. Maybe this necessary action isn't obvious or intuitive enough, so I added a hint (right to the label). Here is a short video. Let me know if you have further questions.

topics_tags.mp4

Hi Hernan. I was hitting enter and saving/updating the topic. When I do that, the new tags are not added. Let's diagnose during the call today. Since nobody else is seeing this, it's possible this is something local to my dev environment.

@dcollie2 dcollie2 force-pushed the 21-base-tagging-implementation branch from 863b4e1 to 9e8b773 Compare March 22, 2025 17:06
@dcollie2 dcollie2 merged commit 1d36786 into main Mar 22, 2025
4 checks passed
@dcollie2 dcollie2 deleted the 21-base-tagging-implementation branch March 22, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base Tagging Implementation

4 participants