-
Notifications
You must be signed in to change notification settings - Fork 6
Add tagging functionality for topics #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9d3b30d to
d8028b0
Compare
1ad7a2b to
5b91cbc
Compare
f6d2e3f to
172ad05
Compare
8ff9b3e to
88ca250
Compare
b392f09 to
3668b6d
Compare
|
I have not had time to fully diagnose, but when I run this locally I am losing the language context for the tags. I'll try to look into it further tonight. |
Oli0li
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hernanvicente for doing this, I've never used that gem for tags so it's interesting to see how it works! I just left a couple of small comments
|
I'm having some troubles with this and I'm not sure if they're local to me or if the scope you're covering is different from what I'm expecting. Basically, adding a tag that doesn't exist is not working. If tags already exist for a language, I can add them using the select box but I cannot create a new tag for that language or for a language without tags. |
|
Hello @dcollie2, to add new tags, the user must press ENTER. Maybe this necessary action isn't obvious or intuitive enough, so I added a hint (right to the label). Here is a short video. Let me know if you have further questions. topics_tags.mp4 |
f56a5ab to
863b4e1
Compare
Hi Hernan. I was hitting enter and saving/updating the topic. When I do that, the new tags are not added. Let's diagnose during the call today. Since nobody else is seeing this, it's possible this is something local to my dev environment. |
863b4e1 to
9e8b773
Compare


What Issue Does This PR Cover, If Any?
Resolves #21
What Changed? And Why Did It Change?
acts-as-taggable-ongemHow Has This Been Tested?
Please Provide Screenshots