Create topics #44
Closed
Create topics #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmarcia
force-pushed
the
create_topics
branch
2 times, most recently
from
7e01f0b to
a3e1e8b
Compare
seanmarcia
force-pushed
the
create_topics
branch
2 times, most recently
from
8d418e7 to
736da1d
Compare
seanmarcia
force-pushed
the
create_topics
branch
from
736da1d to
5a5a9da
Compare
Oli0li
reviewed
Feb 5, 2025
|
|
||
| <div class="mt-4"> | ||
| <div class="col-12 d-flex justify-content-end"> | ||
| <%= form.submit "Create Topic", class: "btn btn-primary me-1 mb-1" %> |
Collaborator
There was a problem hiding this comment.
Since this is also used for the #edit action, maybe changing the wording to "Save" would be better to apply both for #create and #edit.
Suggested change
| <%= form.submit "Create Topic", class: "btn btn-primary me-1 mb-1" %> | |
| <%= form.submit "Save Topic", class: "btn btn-primary me-1 mb-1" %> |
| <div class="col-md-4"> | ||
| <div class="form-group"> | ||
| <%= form.label :title, style: "display: block" %> | ||
| <%= form.text_field :title, id: "basicInput", class: "form-control", autofocus: true %> |
Collaborator
There was a problem hiding this comment.
I see we have a few "id: "basicInput"" in the app, sometimes within the same page, but I don't think we actually need them? I think we got them when we copy/pasted code from Mazer and forgot to remove it.
| t.text :description | ||
| t.references :language, null: false, foreign_key: true | ||
| t.references :provider, null: false, foreign_key: true | ||
| t.boolean :archived, default: false |
Collaborator
There was a problem hiding this comment.
On the wiki, Danny had mentioned using enumerables for states like "active" and "archived". Do we want to do this or should we go with a boolean?
Collaborator
|
Sorry, I hadn't realised we already had another PR for this, so please ignore my comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18