Add user search #52
Merged
Add user search #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "mazer" layout is no longer used as we have moved all the code on application.html.erb. We are not using ApexCharts currently so I removed the lines that were importing scripts for that. I tried writing system tests to test the search and pagination but I couldn't find how to make Capybara see it. It worked when I tested it by hand.
Oli0li
force-pushed
the
add-user-search
branch
from
1459746 to
3460dcd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves 1 task of #9
What Changed? And Why Did It Change?
It adds pagination and search functionality on the User management page.
How Has This Been Tested?
I tried writing system tests but could not find a way to make Capybara see the elements that are being generated with JavaScript, so I ended up only testing this by hand.
Please Provide Screenshots