add search for for topics #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrytrager
force-pushed
the
topic-search-filtering-19
branch
from
ba5862f to
bd76035
Compare
dmitrytrager
commented
Feb 6, 2025
| else | ||
| Topic.active | ||
| end | ||
| Current.user.topics |
Collaborator
Author
There was a problem hiding this comment.
Since we should filter by state, all topics are available for admins.
But for regular user only topics from his providers are available
dmitrytrager
commented
Feb 6, 2025
| params.require(:topic).permit(:title, :description, :uid, :language_id, :provider_id) | ||
| end | ||
|
|
||
| helper_method :search_params |
Collaborator
Author
There was a problem hiding this comment.
We want to use these params for view
dcollie2
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves #19
What Changed? And Why Did It Change?
This PR Introduces form for topic search.
For now it requires pushing "Submit" button, but later I will try to make it work without.
We use existing
GET topicsroute here and several attributes to filter forHow Has This Been Tested?
Added new request specs for
GET topicswith different search optionsPlease Provide Screenshots
Additional Comments
One more thing we can do here is to introduce choices for new selectors that we have. But probably it is better to add separate issues for that