Fix Use of Kernel.open or IO.read or similar sinks with a non-constant value#83
Merged
hsbt merged 1 commit intorubygems:masterfrom Aug 19, 2025
odaysec:patch-1
Merged
Fix Use of Kernel.open or IO.read or similar sinks with a non-constant value#83hsbt merged 1 commit intorubygems:masterfrom odaysec:patch-1
Kernel.open or IO.read or similar sinks with a non-constant value#83hsbt merged 1 commit intorubygems:masterfrom
odaysec:patch-1
Conversation
Kernel.open or IO.read or similar sinks with a non-constant value
Member
|
👍 |
segiddins
approved these changes
Aug 18, 2025
simi
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the problem, replace the call to
open(path, 'wb')withFile.open(path, 'wb'). This ensures that the file is opened for writing without invoking the potentially dangerous behavior ofKernel.open. No other changes are needed, as the rest of the code is compatible withFile.open. The change should be made in theupdate_specsmethod, specifically on line 48 oflib/rubygems/mirror.rb. No new imports or method definitions are required.References
Command Injection. Ruby on Rails Cheat Sheet: Command Injection
Command Injection in RDoc