Skip to content

Conversation

Copy link

Copilot AI commented Jan 4, 2026

Adds missing test coverage for the matching_markets method in the Client class, as identified in PR #7 review feedback.

Changes

  • Added test case in test/domeapi/client_test.rb verifying client.matching_markets returns a Rubyists::Domeapi::MatchingMarkets instance
  • Mirrors existing test pattern for client.polymarket on line 32-34
it 'returns a matching markets instance' do
  _(client.matching_markets).must_be_instance_of Rubyists::Domeapi::MatchingMarkets
end

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@bougyman
Copy link
Member

bougyman commented Jan 4, 2026

@copilot you merged in a commit with an invalid commit message, breaking the explicit requirement of this task.

Copilot AI changed the title [WIP] Address feedback on matching markets for sports by date, ticker, or slug test: add coverage for matching_markets client method Jan 4, 2026
Copilot AI requested a review from bougyman January 4, 2026 20:33
@bougyman bougyman closed this Jan 4, 2026
@bougyman bougyman deleted the copilot/sub-pr-7 branch January 4, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants