fix(trigger): Adds REPLACE option to trigger creation, defaults to true #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables the creation of triggers with the "OR REPLACE" option by default, while still allowing users to opt-out.
- Added the :replace key with a default value of true to DEFAULT_OPTS.
- Updated the create! method to pass the new replace option to the db.create_trigger call.
- Included a new replace method to fetch the option from the trigger options.
bougyman
requested review from
a team,
OpenSourceAlchemist,
afulki,
kthibodeaux and
penguinxr2
KBerryPP
approved these changes
Apr 1, 2025
OpenSourceAlchemist
approved these changes
Apr 2, 2025
stepdadbob
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the "OR REPLACE" to the "CREATE TRIGGER" statement
by default, with an option to opt-out.