Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Jun 23, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.81.0 → 0.86.0) · Repo · Changelog

Release Notes

0.86.0

New features

  • #8147: Add new Style/RedundantFetchBlock cop. (@fatkodima)
  • #8111: Add auto-correct for Style/StructInheritance. (@tejasbubane)
  • #8113: Let expect_offense templates add variable-length whitespace with _{foo}. (@eugeneius)
  • #8148: Support auto-correction for Style/MultilineTernaryOperator. (@koic)
  • #8151: Support auto-correction for Style/NestedTernaryOperator. (@koic)
  • #8142: Add Lint/ConstantResolution cop. (@robotdana)
  • #8170: Support auto-correction for Lint/RegexpAsCondition. (@koic)
  • #8169: Support auto-correction for Lint/RaiseException. (@koic)

Bug fixes

  • #8132: Fix the problem with Naming/MethodName: EnforcedStyle: camelCase and _ or i variables. (@avrusanov)
  • #8115: Fix false negative for Lint::FormatParameterMismatch when argument contains formatting. (@andrykonchin)
  • #8131: Fix false positive for Style/RedundantRegexpEscape with escaped delimiters. (@owst)
  • #8124: Fix a false positive for Lint/FormatParameterMismatch when using named parameters with escaped %. (@koic)
  • #7979: Fix "uninitialized constant DidYouMean::SpellChecker" exception. (@bquorning)
  • #8098: Fix a false positive for Style/RedundantRegexpCharacterClass when using interpolations. (@owst)
  • #8150: Fix a false positive for Layout/EmptyLinesAroundAttributeAccessor when using attribute accessors in if ... else branches. (@koic)
  • #8179: Fix an infinite correction loop error for Layout/MultilineBlockLayout when missing newline before opening parenthesis ( for block body. (@koic)
  • #8185: Fix a false positive for Style/YodaCondition when interpolation is used on the left hand side. (@koic)

Changes

  • #8146: Use UTC in RuboCop todo file generation. (@mauro-oto)
  • #8149: Cop Metrics/CyclomaticComplexity now counts &., ||=, &&= and blocks known to iterate. Default bumped from 6 to 7. (@marcandre)
  • #8178: Mark unsafe for Lint/RaiseException. (@koic)

0.85.1

Bug fixes

  • #8083: Fix an error for Lint/MixedRegexpCaptureTypes cop when using a regular expression that cannot be processed by regexp_parser gem. (@koic)
  • #8081: Fix a false positive for Lint/SuppressedException when empty rescue block in do block. (@koic)
  • #8096: Fix a false positive for Lint/SuppressedException when empty rescue block in defs. (@koic)
  • #8108: Fix infinite loop in Layout/HeredocIndentation auto-correct. (@jonas054)
  • #8042: Fix raising error in Lint::FormatParameterMismatch when it handles invalid format strings and add new offense. (@andrykonchin)

0.85.0

New features

  • #6289: Add new CheckDefinitionPathHierarchy option for Naming/FileName. (@jschneid)
  • #8055: Add new Style/RedundantRegexpCharacterClass cop. (@owst)
  • #8069: New option for expect_offense to help format offense templates. (@marcandre)
  • #7908: Add new Style/RedundantRegexpEscape cop. (@owst)
  • #7978: Add new option OnlyFor to the Bundler/GemComment cop. (@ric2b)
  • #8063: Add new AllowedNames option for Naming/ClassAndModuleCamelCase. (@tejasbubane)
  • #8050: New option --display-only-failed that can be used with --format junit. Speeds up test report processing for large codebases and helps address the sorts of concerns raised at mikian/rubocop-junit-formatter #18. (@burnettk)
  • #7746: Add new Lint/MixedRegexpCaptureTypes cop. (@pocke)

Bug fixes

  • #8008: Fix an error for Lint/SuppressedException when empty rescue block in def. (@koic)
  • #8012: Fix an incorrect autocorrect for Lint/DeprecatedOpenSSLConstant when deprecated OpenSSL constant is used in a block. (@koic)
  • #8017: Fix a false positive for Lint/SuppressedException when empty rescue with comment in def. (@koic)
  • #7990: Fix resolving inherit_gem in remote configs. (@CvX)
  • #8035: Fix a false positive for Lint/DeprecatedOpenSSLConstant when using double quoted string argument. (@koic)
  • #7971: Fix an issue where --disable-uncorrectable would not update uncorrected code with rubocop:todo. (@rrosenblum)
  • #8035: Fix a false positive for Lint/DeprecatedOpenSSLConstant when argument is a variable, method, or consntant. (@koic)

Changes

  • #8056: (Breaking) Remove support for unindent/active_support/powerpack from Layout/HeredocIndentation, so it only recommends using squiggy heredoc. (@bquorning)

0.84.0

New features

  • #7735: NodePattern and AST classes have been moved to the rubocop-ast gem. (@marcandre)
  • #7950: Add new Lint/DeprecatedOpenSSLConstant cop. (@bdewater)
  • #7976: Add AllowAliasSyntax and AllowedMethods options for Layout/EmptyLinesAroundAttributeAccessor. (@koic)
  • #7984: New rake task "check_commit" will run rspec and rubocop on files touched by the last commit. (@marcandre)

Bug fixes

  • #7953: Fix an error for Lint/AmbiguousOperator when a method with no arguments is used in advance. (@koic)
  • #7962: Fix a false positive for Lint/ParenthesesAsGroupedExpression when heredoc has a space between the same string as the method name and (. (@koic)
  • #7967: Style/SlicingWithRange cop now supports any expression as its first index. (@zverok)
  • #7972: Fix an incorrect autocrrect for Style/HashSyntax when using a return value uses return. (@koic)
  • #7886: Fix a bug in AllowComments logic in Lint/SuppressedException. (@jonas054)
  • #7991: Fix an error for Layout/EmptyLinesAroundAttributeAccessor when attribute method is method chained. (@koic)
  • #7993: Fix a false positive for Migration/DepartmentName when a disable comment contains an unexpected character for department name. (@koic)

Changes

  • #7952: (Breaking) Change the max line length of Layout/LineLength to 120 by default. (@koic)
  • #7959: Change enforced style to conditionals for Style/AndOr. (@koic)
  • #7985: Add EnforcedStyle for Style/DoubleNegation cop and allow double nagation in contexts that use boolean as a return value. (@koic)

0.83.0

New features

  • #7951: Include rakefile file by default. (@jethrodaniel)
  • #7921: Add new Style/SlicingWithRange cop. (@zverok)
  • #7895: Include .simplecov file by default. (@robotdana)
  • #7916: Support autocorrection for Lint/AmbiguousRegexpLiteral. (@koic)
  • #7917: Support autocorrection for Lint/UselessAccessModifier. (@koic)
  • #595: Add ERB pre-processing for configuration files. (@jonas054)
  • #7918: Support autocorrection for Lint/AmbiguousOperator. (@koic)
  • #7937: Support autocorrection for Style/IfWithSemicolon. (@koic)
  • #3696: Add AllowComments option to Lint/EmptyWhen cop. (@koic)
  • #7910: Support autocorrection for Lint/ParenthesesAsGroupedExpression. (@koic)
  • #7925: Support autocorrection for Layout/ConditionPosition. (@koic)
  • #7934: Support autocorrection for Lint/EnsureReturn. (@koic)
  • #7922: Add new Layout/EmptyLineAroundAttributeAccessor cop. (@koic)

Bug fixes

  • #7929: Fix Style/FrozenStringLiteralComment to accept frozen_string_literal anywhere in leading comment lines. (@jeffcarbs)
  • #7882: Fix Style/CaseEquality when AllowOnConstant is true and the method receiver is implicit. (@rafaelfranca)
  • #7790: Fix --parallel and --ignore-parent-exclusion combination. (@jonas054)
  • #7881: Fix --parallel and --force-default-config combination. (@jonas054)
  • #7635: Fix a false positive for Style/MultilineWhenThen when then required for a body of when is used. (@koic)
  • #7905: Fix an error when running rubocop --only or rubocop --except options without cop name argument. (@koic)
  • #7903: Fix an incorrect autocorrect for Style/HashTransformKeys and Style/HashTransformValues cops when line break before to_h method. (@diogoosorio, @koic)
  • #7899: Fix an infinite loop error for Layout/SpaceAroundOperators with Layout/ExtraSpacing when using ForceEqualSignAlignment: true. (@koic)
  • #7885: Fix Style/IfUnlessModifier logic when tabs are used for indentation. (@jonas054)
  • #7909: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using an intended grouped parentheses. (@koic)
  • #7913: Fix a false positive for Lint/LiteralAsCondition when using true literal in while and similar cases. (@koic)
  • #7928: Fix a false message for Style/GuardClause when using and or or operators for guard clause in then or else branches. (@koic)
  • #7928: Fix a false positive for Style/GuardClause when assigning the result of a guard condition with else. (@koic)

Changes

  • #7860: Change AllowInHeredoc option of Layout/TrailingWhitespace to true by default. (@koic)
  • #7094: Clarify alignment in Layout/MultilineOperationIndentation. (@jonas054)
  • #4245: (Breaking) Inspect all files given on command line unless --only-recognized-file-types is given. (@jonas054)
  • #7390: (Breaking) Enabling a cop overrides disabling its department. (@jonas054)
  • #7936: Mark Lint/BooleanSymbol as unsafe. (@laurmurclar)
  • #7948: Mark unsafe for Style/OptionalArguments. (@koic)
  • #7931: Remove dependency on the jaro_winkler gem, instead depending on did_you_mean. This may be a breaking change for RuboCop libraries calling NameSimilarity#find_similar_name. (@bquorning)

0.82.0

New features

Bug fixes

  • #7871: Fix an auto-correction bug in Lint/BooleanSymbol. (@knu)
  • #7842: Fix a false positive for Lint/RaiseException when raising Exception with explicit namespace. (@koic)
  • #7834: Fix Lint/UriRegexp to register offense with array arguments. (@tejasbubane)
  • #7841: Fix an error for Style/TrailingCommaInBlockArgs when lambda literal (->) has multiple arguments. (@koic)
  • #7842: Fix a false positive for Lint/RaiseException when Exception without cbase specified under the namespace Gem by adding AllowedImplicitNamespaces option. (@koic)
  • Style/IfUnlessModifier does not infinite-loop when autocorrecting long lines which use if/unless modifiers and have multiple statements separated by semicolons. (@alexdowad)
  • rubocop-hq/rubocop-rails#127: Use ConfigLoader.default_configuration for the default config. (@hanachin)

Changes

  • (Breaking) Renamed Layout/Tab cop to Layout/IndentationStyle. (@DracoAter)
  • #7869: (Breaking) Drop support for Ruby 2.3. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ ast (indirect, 2.4.0 → 2.4.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 7 commits:

↗️ parallel (indirect, 1.19.1 → 1.19.2) · Repo

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ parser (indirect, 2.7.0.5 → 2.7.1.4) · Repo · Changelog

Release Notes

2.7.1.4 (from changelog)

Features implemented:

  • ruby28.y: add find pattern. (#714) (Ilya Bylich)
  • lexer.rl: reject ->... and ->(...) with the same error. (#713) (Ilya Bylich)
  • ruby28.y: accept leading args before forward arg. (#712) (Ilya Bylich)
  • Added emit_forward_arg compatibility flag. (#710) (Ilya Bylich)
  • ruby28.y: include entire lambda expr in lambda rule. (#708) (Ilya Bylich)
  • ruby28.y: extracted excessed_comma rule. (#706) (Ilya Bylich)
  • Source::TreeRewriter: Improved merging and representations (#703) (Marc-André Lafortune)

Bugs fixed:

  • ruby*.y: fixed context inside lambda args and module. (#709) (Ilya Bylich)

2.7.1.3 (from changelog)

API modifications:

  • fixed all warnings. tests are running in verbose mode now. (#685) (Ilya Bylich)

Features implemented:

  • ruby-[parse, rewrite]: add legacy switches (#699) (Marc-André Lafortune)
  • Added Parser::Source::Range#to_range. (#697) (Ilya Bylich)
  • ruby28.y: support rescue modifier in endless method definition. (#696) (Ilya Bylich)
  • ruby28.y: unify kwrest and no-kwrest rules. (#694) (Ilya Bylich)
  • ruby28.y: add right hand assignment (#682) (Vladimir Dementyev)

Bugs fixed:

  • fix Comment.associate for postfix conditions/loops (#688) (Marc-André Lafortune)

2.7.1.0 (from changelog)

API modifications:

  • Bump ruby versions to 2.4.10, 2.5.8, 2.6.6, 2.7.1. (#665) (Ilya Bylich)

Features implemented:

  • ruby27.y: allow newlines inside braced pattern. (#664) (Ilya Bylich)
  • ruby27.y: Allow trailing comma in hash pattern (#661) (Koichi ITO)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 45 commits:

🆕 rubocop-ast (added, 0.0.3)

🗑️ jaro_winkler (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Jul 7, 2020

Closed in favor of #289.

@depfu depfu bot closed this Jul 7, 2020
@depfu depfu bot deleted the depfu/update/rubocop-0.86.0 branch July 7, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant