-
-
Notifications
You must be signed in to change notification settings - Fork 238
Introduce logic for cvss_v4 severity #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2464e66 to
c7b9d1a
Compare
c7b9d1a to
c9906be
Compare
|
Hello @postmodern, sorry for shameless ping. Can I get your opinion on this PR, is there anything missing here preventing it from being merged? |
lib/bundler/audit/version.rb
Outdated
| module Audit | ||
| # bundler-audit version | ||
| VERSION = '0.9.3' | ||
| VERSION = "0.10.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't bump the version in a PR. There's already a 0.10.0 branch that you could branch off of, or let me merge on your changes into the 0.10.0 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Sorry, I wasn't aware about this, if it's okay with you I would happily defer to you when chosing target merge branch
| # | ||
| def criticality | ||
| if cvss_v3 | ||
| case cvss_v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're using the same logic for calculating criticality for both cvss_v3 and cvss_v4, why not just combine the two?
if cvss_v4 || cvss_v3
case cvss_v4 || cvss_v3
when ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, this makes perfect sense! Thank you, I pushed appropriate changes 🙇🏻
c9906be to
afe8f88
Compare
afe8f88 to
b6a27ef
Compare
Hello Team,
I would like to introduce logic for properly rating severity for vulnerabilities which are estimated using only
CVSS:4.0. This is a followup to rubysec/ruby-advisory-db#654Currently vulnerabilities which are estimated using only
CVSS:4.0are using default fallback and are being marked asseverity:unknown.According to specification docs I think severity did not change between 3.0 and 4.0 standards
I did some refactoring based on code climate suggestions
Here is an example:
Using
bundler-audit:0.9.2Using
bundler-audit:0.10.0Let me know if there is anything else I should adjust