Adding support to cancel "restore" and "real_destroy" actions#283
Open
arieliten wants to merge 1 commit intorubysherpas:rails4from
Open
Adding support to cancel "restore" and "real_destroy" actions#283arieliten wants to merge 1 commit intorubysherpas:rails4from
arieliten wants to merge 1 commit intorubysherpas:rails4from
Conversation
Contributor
|
Canceling callbacks with |
|
What if we are not using Rails 5.0? |
|
I'd love to see this get merged. We've been using a custom fork with this change for several months now and would much rather have it in the main repo. Any outlook for accepting it? |
Collaborator
|
Good job @arieliten. Can you provide a test for this change? |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the callbacks for
before_restoreandbefore_real_destroycan't be canceled (via returningfalse) like any other normal ActiveModel::Callback. So here I'm adding the support to cancel any of those actions (restoreorreal_destroy) by returningfalsein their callbacks.