Skip to content

Fix offset migrations #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pips- wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix offset migrations #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/Task/Db/Migrate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,12 @@ private function migrate_from_offset($steps, $current_version, $direction)
$this->_return .= "\nsteps: " . $steps . " $direction\n";
}

// If we are not at the bottom then adjust our index (to satisfy array_slice)
if ($current_index == -1 && $direction === 'down') {
$available = array();
} else {
if ($direction === 'up') {
$current_index += 1;
} else {
$current_index += $steps;
}
// If we are not at the bottom then adjust our index (to satisfy array_slice)
$current_index += 1;

// check to see if we have enough migrations to run - the user
// might have asked to run more than we have available
$available = array_slice($migrations, $current_index, $steps);
Expand Down