Skip to content

chore: tiktok audience supported source types#2337

Open
achettyiitr wants to merge 2 commits intodevelopfrom
chore.tiktok-audience-source-types
Open

chore: tiktok audience supported source types#2337
achettyiitr wants to merge 2 commits intodevelopfrom
chore.tiktok-audience-source-types

Conversation

@achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Feb 10, 2026

🔒 Scanned for secrets using gitleaks 8.29.1

What are the changes introduced in this PR?

  • Removing cloud from supportedSourceTypes for TikTok Audience.

What is the related Linear task?

  • Resolves INT-5838

Summary by CodeRabbit

  • Chores
    • TikTok Audience destination now supports warehouse sources only; cloud configuration paths removed. Added audienceId and isHashRequired fields and moved consent/cookie-purpose settings under the warehouse configuration.
  • Tests
    • Validation tests updated for warehouse-only configuration; cloud-related test cases and error expectations removed or adjusted.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

Removed all "cloud" support from the TikTok Audience destination: configuration, JSON schema validation, and test fixtures now only include and validate the "warehouse" source type and connection mode (audienceId moved into warehouse config).

Changes

Cohort / File(s) Summary
Destination config
src/configurations/destinations/tiktok_audience/db-config.json
Removed "cloud" from supportedSourceTypes and supportedConnectionModes; deleted the cloud block under destConfig; added audienceId to destConfig.warehouse.
Schema validation
src/configurations/destinations/tiktok_audience/schema.json
Eliminated cloud branches for oneTrustCookieCategories, ketchConsentPurposes, and consentManagement; added top-level audienceId and isHashRequired; consolidated all consent/cookie/purpose definitions under warehouse; reintroduced additionalProperties: true.
Tests / fixtures
test/data/validation/destinations/tiktok_audience.json
Removed cloud-specific test cases and expected errors; test fixtures and validation expectations adjusted to warehouse-only shapes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I nibbled the cloud from the config vine,
Planted the audienceId where warehouses shine.
Schemas now tidy, tests trimmed and light,
Hopping through JSON, all neat and right.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete, missing critical sections including objectives, dependency information, testing details, and the developer/reviewer checklists required by the template. Complete the description with the missing sections: objectives of changes, impact on existing capabilities, new dependencies, test suite changes, and all required checklist items from the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: tiktok audience supported source types' clearly and concisely summarizes the main change of removing cloud from supportedSourceTypes for TikTok Audience.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore.tiktok-audience-source-types

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@achettyiitr achettyiitr force-pushed the chore.tiktok-audience-source-types branch from 8ea3a88 to 938b426 Compare February 10, 2026 21:50
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a3f4ad6) to head (3591007).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #2337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           72        72           
  Branches         8         8           
=========================================
  Hits            72        72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@achettyiitr achettyiitr force-pushed the chore.tiktok-audience-source-types branch from 938b426 to 0f75194 Compare February 10, 2026 21:53
🔒 Scanned for secrets using gitleaks 8.29.1
@achettyiitr achettyiitr force-pushed the chore.tiktok-audience-source-types branch from 0f75194 to 57178f1 Compare February 10, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant