Skip to content

fix: update regex to support empty spaces in query params#2347

Merged
ItsSudip merged 1 commit intodevelopfrom
fix/emptySpaces
Feb 17, 2026
Merged

fix: update regex to support empty spaces in query params#2347
ItsSudip merged 1 commit intodevelopfrom
fix/emptySpaces

Conversation

@ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Feb 17, 2026

What are the changes introduced in this PR?

We are adding support for spaces in query parameters of Http Webhook destination.

What is the related Linear task?

https://linear.app/rudderstack/issue/INT-5898/validation-rejects-sql-constants-with-spaces-in-webhooks

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • My test cases and placeholders use only masked/sample values for sensitive fields

  • Is the PR limited to 10 file changes & one task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

Release Notes

  • New Features

    • Expanded HTTP destination configuration validation to support spaces in query parameters, path parameters, and header field names, enabling more flexible parameter configurations.
  • Tests

    • Added test coverage for string parameters containing spaces in HTTP destination configurations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request updates HTTP destination configuration validation patterns to permit space characters in field values. The regex patterns in both schema and UI configuration files are widened to include spaces, and corresponding test cases are added to validate the new behavior across queryParams, pathParams, and headers.

Changes

Cohort / File(s) Summary
Configuration Schema & UI Patterns
src/configurations/destinations/http/schema.json, src/configurations/destinations/http/ui-config.json
Updated regex validation patterns for "from" and "Value" fields to allow space characters and adjusted dash escaping. Widened accepted character set in queryParams, pathParams, and headers mappings.
Test Data
test/data/validation/destinations/http.json
Added new test cases to queryParams array including a "String with spaces" mapping to validate the expanded character validation patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A space hopped in where dashes once played,
Through schema and patterns, new pathways were laid.
The rabbit approves—more room to explore,
For strings with white gaps we couldn't allow before! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating regex to support spaces in query parameters, which aligns with the changeset modifications to regex patterns.
Description check ✅ Passed The description covers the key sections including changes overview, related Linear task, and objectives, though the developer checklist items remain unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/emptySpaces

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cc78e09) to head (f0f4ebe).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #2347   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           72        72           
  Branches         8         8           
=========================================
  Hits            72        72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ItsSudip ItsSudip merged commit 911e9e4 into develop Feb 17, 2026
15 checks passed
@ItsSudip ItsSudip deleted the fix/emptySpaces branch February 17, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants