Skip to content

chore: update callout of lookupfield of hubspot integration#2353

Merged
ItsSudip merged 1 commit intodevelopfrom
chore/updateCallout
Feb 18, 2026
Merged

chore: update callout of lookupfield of hubspot integration#2353
ItsSudip merged 1 commit intodevelopfrom
chore/updateCallout

Conversation

@ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Feb 18, 2026

What are the changes introduced in this PR?

Update the callout of lookupfield to explain the behaviour of delivering data to HubSpot in the presence and absence of a unique field.

What is the related Linear task?

https://linear.app/rudderstack/issue/INT-5821/hubspot-update-lookupfield-tooltip-for-unique-property-requirement

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • My test cases and placeholders use only masked/sample values for sensitive fields

  • Is the PR limited to 10 file changes & one task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

Documentation

  • Enhanced HubSpot property selection guidance to clarify performance differences: unique properties enable batch upsert with higher throughput; non-unique properties remain supported but use a slower search-based flow.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Updated UI guidance text in HubSpot destination configuration to clarify performance implications: unique properties enable batch upsert with higher throughput, while non-unique properties use slower search-based operations. The value is retrieved from event traits.

Changes

Cohort / File(s) Summary
HubSpot Configuration
src/configurations/destinations/hs/ui-config.json
Updated UI guidance note for HubSpot property selection, explaining performance differences between unique and non-unique properties in upsert operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through config files,
Updating notes with helpful smiles,
"Unique properties," it declares with glee,
"Make upserts fast and fancy free!" 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating UI guidance text for the HubSpot lookupfield property selection callout.
Description check ✅ Passed The PR description follows the template structure with all required sections completed, including changes summary, Linear task reference, and comprehensive checklists.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/updateCallout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d605b93) to head (d67587c).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #2353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           72        72           
  Branches         8         8           
=========================================
  Hits            72        72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ItsSudip ItsSudip merged commit 291fb9e into develop Feb 18, 2026
15 checks passed
@ItsSudip ItsSudip deleted the chore/updateCallout branch February 18, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants