Conversation
🔒 Scanned for secrets using gitleaks 8.28.0
📝 WalkthroughWalkthroughA new "adjustmentType" configuration field is being added to the Google AdWords Enhanced Conversions destination across three configuration files: database config gains the field entry, schema defines its type and allowed values (ENHANCEMENT, RESTATEMENT), and UI config adds the corresponding field with feature flag gating. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2365 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 72 72
Branches 8 8
=========================================
Hits 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔒 Scanned for secrets using gitleaks 8.28.0
What are the changes introduced in this PR?
Exposes an Adjustment Type field for the GAEC destination so users can choose ENHANCEMENT or RESTATEMENT. The field is gated by the feature flag AMP_enable-GAEC-adjustment-type.
Changes
schema.json: Add adjustmentType with enum ["ENHANCEMENT", "RESTATEMENT"] and default "ENHANCEMENT".
Related
rudder-transformer: rudderlabs/rudder-transformer#5016
What is the related Linear task?
Resolves INT-6008
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit