Skip to content

feat: add adjustmentType for GAEC#2365

Open
maheshkutty wants to merge 1 commit intodevelopfrom
feat.gaec_adjustment_type
Open

feat: add adjustmentType for GAEC#2365
maheshkutty wants to merge 1 commit intodevelopfrom
feat.gaec_adjustment_type

Conversation

@maheshkutty
Copy link
Collaborator

@maheshkutty maheshkutty commented Mar 2, 2026

🔒 Scanned for secrets using gitleaks 8.28.0

What are the changes introduced in this PR?

Exposes an Adjustment Type field for the GAEC destination so users can choose ENHANCEMENT or RESTATEMENT. The field is gated by the feature flag AMP_enable-GAEC-adjustment-type.

Changes

  • ui-config.json: New single-select field with options ENHANCEMENT and RESTATEMENT (default: ENHANCEMENT), shown when AMP_enable-GAEC-adjustment-type is true.
  • db-config.json: Add adjustmentType to defaultConfig.
    schema.json: Add adjustmentType with enum ["ENHANCEMENT", "RESTATEMENT"] and default "ENHANCEMENT".

Related
rudder-transformer: rudderlabs/rudder-transformer#5016

image image

What is the related Linear task?

Resolves INT-6008

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • My test cases and placeholders use only masked/sample values for sensitive fields

  • Is the PR limited to 10 file changes & one task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

  • New Features
    • Added Adjustment Type configuration option for Google AdWords Enhanced Conversions. Users can now select between ENHANCEMENT (default) or RESTATEMENT when configuring this destination.

🔒 Scanned for secrets using gitleaks 8.28.0
@maheshkutty maheshkutty changed the title feat: add adjustmentType of GAEC feat: add adjustmentType for GAEC Mar 2, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

📝 Walkthrough

Walkthrough

A new "adjustmentType" configuration field is being added to the Google AdWords Enhanced Conversions destination across three configuration files: database config gains the field entry, schema defines its type and allowed values (ENHANCEMENT, RESTATEMENT), and UI config adds the corresponding field with feature flag gating.

Changes

Cohort / File(s) Summary
Google AdWords Enhanced Conversions Configuration
src/configurations/destinations/google_adwords_enhanced_conversions/db-config.json, src/configurations/destinations/google_adwords_enhanced_conversions/schema.json, src/configurations/destinations/google_adwords_enhanced_conversions/ui-config.json
Introduces new adjustmentType field with enum values ENHANCEMENT and RESTATEMENT, default ENHANCEMENT. Field is added to default config array, defined in schema with type string, and exposed in UI as single-select dropdown gated behind feature flag AMP_enable-GAEC-adjustment-type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop and a bound, new adjustments are found!
Enhancement or restatement, the choice now goes 'round,
With flags keeping watch on our feature so bright,
Google's conversions dance in the digital light! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add adjustmentType for GAEC' directly and clearly describes the main change—adding a new adjustmentType field to the Google AdWords Enhanced Conversions configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description covers main changes, related task, and objectives per template structure; most required sections are completed with substantive details rather than N/A placeholders.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat.gaec_adjustment_type

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a3f4ad6) to head (d154e5b).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #2365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           72        72           
  Branches         8         8           
=========================================
  Hits            72        72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants