Skip to content

feat: cleanup includeKeys in destination definitions#2368

Closed
saikumarrs wants to merge 0 commit intomainfrom
hotfix/includekeys-cleanup
Closed

feat: cleanup includeKeys in destination definitions#2368
saikumarrs wants to merge 0 commit intomainfrom
hotfix/includekeys-cleanup

Conversation

@saikumarrs
Copy link
Member

Summary

  • Removes secret/internal keys (apiKey, apiSecret, mid, advertiserId, etc.) from config.includeKeys arrays across 26 destinations
  • These keys should not be exposed to client-side SDKs via the source configuration response

Destinations Updated

af, awin, candu, canny, clickup, custify, facebook_offline_conversions, freshmarketer, freshsales, klaviyo_bulk_upload, mailjet, mailmodo, marketo_static_list, mautic, new_relic, pagerduty, persistiq, rakuten, refiner, smartly, snapchat_custom_audience, stormly, user, userpilot, wootric, zapier

Test plan

  • Verify that the removed keys are either secret keys or not required on the client-side
  • Run existing tests: npm test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 56c0e1e1-d0ce-41ed-8564-c1a754f1377a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/includekeys-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (010cde3) to head (4c8955c).
⚠️ Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2368   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           72        72           
  Branches         8         8           
=========================================
  Hits            72        72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saikumarrs saikumarrs closed this Mar 4, 2026
@saikumarrs saikumarrs force-pushed the hotfix/includekeys-cleanup branch from 4c8955c to 010cde3 Compare March 4, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant