Skip to content

fix(shopify): extract email to context.traits for pixel app events#5041

Merged
ItsSudip merged 2 commits intohotfix/16hMar2026from
fix/shopify
Mar 16, 2026
Merged

fix(shopify): extract email to context.traits for pixel app events#5041
ItsSudip merged 2 commits intohotfix/16hMar2026from
fix/shopify

Conversation

@ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Mar 16, 2026

🔒 Scanned for secrets using gitleaks 8.28.0

We are getting email inside data.checkout for checkout-related events like checkout_started, checkout_address_info_submitted, payment_info_submitted, etc. But we are not mapping them properly to context.traits.email, which is breaking the event flow in downstream destinations like Google Ads enhanced conversion. So, updated the logic to consider the mapping for checkout-related events.

What is the related Linear task?

Resolves INT-6075

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

🔒 Scanned for secrets using gitleaks 8.28.0
@ItsSudip ItsSudip requested a review from a team as a code owner March 16, 2026 06:00
@ItsSudip ItsSudip requested review from krishna2020 and shekhar-rudder and removed request for a team March 16, 2026 06:00
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 30f85543-237e-468e-a202-15afb335e63c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/shopify
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (d281d8f) to head (2692b33).
⚠️ Report is 4 commits behind head on hotfix/16hMar2026.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           hotfix/16hMar2026    #5041      +/-   ##
=====================================================
- Coverage              92.32%   92.27%   -0.05%     
=====================================================
  Files                    657      656       -1     
  Lines                  36139    35915     -224     
  Branches                8531     8468      -63     
=====================================================
- Hits                   33365    33142     -223     
+ Misses                  2557     2535      -22     
- Partials                 217      238      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

message.setProperty('context.shopifyDetails', shopifyDetails);

// extract email from checkout data for pixel events
const email = data?.checkout?.email;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is applicable only for checkout events, move it to the respective functions under case blocks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, moved it to the checkout events section.

🔒 Scanned for secrets using gitleaks 8.28.0
@ItsSudip ItsSudip requested a review from krishna2020 March 16, 2026 07:27
@sonarqubecloud
Copy link

@ItsSudip ItsSudip merged commit 839a19a into hotfix/16hMar2026 Mar 16, 2026
31 checks passed
@ItsSudip ItsSudip deleted the fix/shopify branch March 16, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants