-
Notifications
You must be signed in to change notification settings - Fork 62
chore: Bump React to 19, Recharts to 3, and Mantine to 8.2 #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump React to 19, Recharts to 3, and Mantine to 8.2 #435
Conversation
13e751e
to
f688bac
Compare
f688bac
to
d35f50f
Compare
Hmm, most of the horizontal grid lines on the "contributions" bar chart are gone... |
There's also this: |
|
The switching pages behavior for the logo animation has always been finicky with
|
I think the problem is React's dev mode double-rendering doesn't play well with our code, but the live-site doesn't double render so it's fine. |
So the actual regression here is just those horizontal bars. Maybe recharts' default bar-chart behavior changed. |
My guess: Recharts removed the middle-lines by default but added a configuration to get them back, but @mantine/charts doesn't support modifying that configuration since it didn't exist in Recharts 2. |
and... as unfortunate as that is, is it a blocker? |
Not imo, share a before and after screenshot here and/or on Discord and ask for others to weigh in I'd say. |
Yeah with those 3 commands, the placeholder and logo work properly when switching back to the main page. |
By the way, check the #website channel in Discord. I found something to restore the old behavior. It makes zero sense though... |
d35f50f
to
e1a3de3
Compare
… bar chart Credit to @danielhjacobs for finding it.
e1a3de3
to
8ceda1d
Compare
I've added your workaround for the grid lines, @danielhjacobs. If you're okay with all this, please merge. |
Let's see whether doing all at once works...