Skip to content

Conversation

torokati44
Copy link
Member

Let's see whether doing all at once works...

@torokati44 torokati44 requested a review from danielhjacobs July 24, 2025 09:31
@torokati44 torokati44 force-pushed the recharts-3-mantine-8-react-19 branch 2 times, most recently from 13e751e to f688bac Compare July 24, 2025 09:39
@torokati44 torokati44 force-pushed the recharts-3-mantine-8-react-19 branch from f688bac to d35f50f Compare July 24, 2025 14:53
@torokati44 torokati44 enabled auto-merge (rebase) July 24, 2025 14:54
@torokati44 torokati44 disabled auto-merge July 24, 2025 14:54
@torokati44
Copy link
Member Author

Hmm, most of the horizontal grid lines on the "contributions" bar chart are gone...
And when I'm switching back from eg. the Downloads page to "About Ruffle", the placeholder image doesn't disappear, the logo animation starts playing on top of it...

@torokati44
Copy link
Member Author

There's also this:
⚠ metadataBase property in metadata export is not set for resolving social open graph or twitter images, using "http://localhost:3000". See https://nextjs.org/docs/app/api-reference/functions/generate-metadata#metadatabase
but this might be some preexisting thing

@danielhjacobs
Copy link
Collaborator

metadataBase property in metadata export is not set for resolving social open graph or twitter images, using "http://localhost:3000". See https://nextjs.org/docs/app/api-reference/functions/generate-metadata#metadatabase is definitely pre-existing.

@danielhjacobs
Copy link
Collaborator

The switching pages behavior for the logo animation has always been finicky with npm run dev, have you tried simulating what we actually do?

npm install
npx --no-install next build
npx serve@latest out

@danielhjacobs
Copy link
Collaborator

I think the problem is React's dev mode double-rendering doesn't play well with our code, but the live-site doesn't double render so it's fine.

@danielhjacobs
Copy link
Collaborator

So the actual regression here is just those horizontal bars. Maybe recharts' default bar-chart behavior changed.

@danielhjacobs
Copy link
Collaborator

My guess: Recharts removed the middle-lines by default but added a configuration to get them back, but @mantine/charts doesn't support modifying that configuration since it didn't exist in Recharts 2.

@torokati44
Copy link
Member Author

and... as unfortunate as that is, is it a blocker?

@danielhjacobs
Copy link
Collaborator

danielhjacobs commented Jul 24, 2025

Not imo, share a before and after screenshot here and/or on Discord and ask for others to weigh in I'd say.

@torokati44
Copy link
Member Author

The switching pages behavior for the logo animation has always been finicky with npm run dev, have you tried simulating what we actually do?

Yeah with those 3 commands, the placeholder and logo work properly when switching back to the main page.

@danielhjacobs
Copy link
Collaborator

By the way, check the #website channel in Discord. I found something to restore the old behavior. It makes zero sense though...

@torokati44 torokati44 force-pushed the recharts-3-mantine-8-react-19 branch from d35f50f to e1a3de3 Compare July 28, 2025 17:29
@torokati44 torokati44 force-pushed the recharts-3-mantine-8-react-19 branch from e1a3de3 to 8ceda1d Compare July 28, 2025 17:31
@torokati44
Copy link
Member Author

I've added your workaround for the grid lines, @danielhjacobs. If you're okay with all this, please merge.

@torokati44 torokati44 changed the title chore: Bump react to 19, recharts to 3, mantine to 8.2 chore: Bump React to 19, Recharts to 3, and Mantine to 8.2 Jul 28, 2025
@danielhjacobs danielhjacobs merged commit c9e6bc1 into ruffle-rs:master Jul 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants