Skip to content

Conversation

torokati44
Copy link
Member

@torokati44 torokati44 requested a review from danielhjacobs July 24, 2025 20:13
@torokati44
Copy link
Member Author

torokati44 commented Jul 24, 2025

Hmm, actually, is this also occurring on the live deployment on GHA? 🤔

@torokati44
Copy link
Member Author

Oh, probably not, because of the

        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          BASE_URL: https://ruffle.rs

In the workflow YML file.
So, is this not even necessary, or a good idea...? 🤔
If so, feel free to close.

@danielhjacobs
Copy link
Collaborator

Can confirm that while npx --no-install next build produces a warning, BASE_URL=https://ruffle.rs npx --no-install next build does not, and that's already noted https://github.com/ruffle-rs/ruffle-rs.github.io/tree/51fba776965b1f5d6daaa0f6cffeee013bafa825?tab=readme-ov-file#configure-url. Personally I have never set it since it didn't seem necessary and the used default seemed fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants