Skip to content

compatibility: Use a better workaround for the CartesianGrid issue #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

compatibility: Use a better workaround for the CartesianGrid issue #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/app/compatibility/weekly_contributions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
"use client";
import { ReferenceLine } from "recharts";
import { BarChart } from "@mantine/charts";
import { Paper, Text } from "@mantine/core";
import classes from "./weekly_contributions.module.css";
Expand Down Expand Up @@ -36,6 +35,9 @@ export function WeeklyContributions({ data }: { data: DataPoint[] }) {
h={300}
w="100%"
data={data}
// This manually updated grid property is a workaround for https://github.com/mantinedev/mantine/issues/8110,
// a regression with switching to Recharts 3. TODO: Remove when fixed.
gridProps={{ yAxisId: "left" }}
dataKey="week"
series={[{ name: "Commits", color: "ruffle-orange" }]}
tooltipProps={{
Expand All @@ -44,10 +46,6 @@ export function WeeklyContributions({ data }: { data: DataPoint[] }) {
),
}}
className={classes.chart}
>
{/* This invisible line is a workaround for https://github.com/mantinedev/mantine/issues/8110,
a regression with switching to Recharts 3. TODO: Remove when fixed. */}
<ReferenceLine y={0} stroke="transparent" ifOverflow="extendDomain" />
</BarChart>
/>
);
}