A new error event has been added to the player's panic function. #21253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-web
kjarosh
reviewed
Aug 17, 2025
Comment on lines
+156
to
+161
| /** | ||
| * Triggered when the ruffle player panict. | ||
| * | ||
| * @event RufflePlayer#error | ||
| */ | ||
| static PLAYER_ERROR = "error"; |
There was a problem hiding this comment.
I'd go with
Suggested change
| /** | |
| * Triggered when the ruffle player panict. | |
| * | |
| * @event RufflePlayer#error | |
| */ | |
| static PLAYER_ERROR = "error"; | |
| /** | |
| * Triggered when the Ruffle player panics. | |
| * | |
| * @event RufflePlayer#panicked | |
| */ | |
| static PANICKED = "panicked"; |
| @@ -2023,7 +2031,9 @@ export class InnerPlayer { | |||
| } | |||
|
|
|||
| errorArray.push(this.getPanicData()); | |||
|
|
|||
|
|
|||
| this.element.dispatchEvent(new CustomEvent(InnerPlayer.PLAYER_ERROR, error)); | |||
There was a problem hiding this comment.
You can pass custom data in detail:
Suggested change
| this.element.dispatchEvent(new CustomEvent(InnerPlayer.PLAYER_ERROR, error)); | |
| this.element.dispatchEvent(new CustomEvent(InnerPlayer.PANICKED, { detail: { error } })); |
|
Thanks for the PR BTW, this feature seems reasonable for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
I couldn’t find a simple way to catch a player panic from host code.
Could Ruffle fire an
errorevent when this happens? Then we could do:I opened a small PR with a draft implementation, happy to tweak it as needed.
Love the project, thanks for all the hard work!