Skip to content

core: Force correct alignment for DisplayObjectBase #21313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

core: Force correct alignment for DisplayObjectBase #21313

merged 1 commit into from
Aug 13, 2025

Conversation

moulins
Copy link
Contributor

@moulins moulins commented Aug 12, 2025

On certain architectures (e.g. 32-bits Android), f64s are only 4-aligned, so we need to increase the alignment of DisplayObjectBase to always match with its subclasses.

@moulins moulins added A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) labels Aug 12, 2025
torokati44
torokati44 reviewed Aug 12, 2025
View reviewed changes
torokati44
torokati44 reviewed Aug 12, 2025
View reviewed changes
adrian17
adrian17 approved these changes Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@adrian17 adrian17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also feels like that other unrelated change shouldn't be included.

@moulins moulins force-pushed the fix-dobj-align branch 2 times, most recently from a052ec4 to 8ca09e5 Compare August 13, 2025 12:08
@moulins
core: Force correct alignment for DisplayObjectBase
fc5a7d2 
On certain architectures (e.g. 32-bits Android), `f64`s are only 4-aligned, so
we need to increase the alignment of `DisplayObjectBase` to always match with
its subclasses.
@moulins moulins merged commit cdb88d8 into ruffle-rs:master Aug 13, 2025
24 checks passed
@moulins moulins deleted the fix-dobj-align branch August 13, 2025 13:40
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Aug 17, 2025
@Hancock33
Updates on Aug 14, 2025 20:01
2ef9653 
----------------------------------------------------------------------------------
clk.mk 07e96c10d24fb77fbf3b4cd20f514c75096e6213 # Version: Commits on Aug 13, 2025
----------------------------------------------------------------------------------
Merge pull request #1533 from TomHarte/MultifacetedCall

Further implement the 80286,

------------------------------------------------------------------------------------------
dolphin-emu.mk aa45b7fe61c805f428c03bfaeba6e80bdb6b0e59 # Version: Commits on Aug 13, 2025
------------------------------------------------------------------------------------------
Merge pull request #13867 from TryTwo/gfx_bug_fix

GFX: Fix bugs for AbstractStagingTextures that perform an Upload.,

------------------------------------------------------------------------------------------
duckstation.mk 8597873330e020f3af0f853bd54f765a0f28c796 # Version: Commits on Aug 14, 2025
------------------------------------------------------------------------------------------
SDLInputSource: Fix DirectInput,

------------------------------------------------------------------------------------
fsuae.mk 195e3d43c0ce921f7ddc45f3d1e44fa858823d37 # Version: Commits on Aug 13, 2025
------------------------------------------------------------------------------------
zstd package build script fix for macOS,

-------------------------------------------------------------------------------------
ppsspp.mk 78263413524030a5244e7c91dedd82a85b016acc # Version: Commits on Aug 14, 2025
-------------------------------------------------------------------------------------
Merge pull request #20714 from Dicot0721/lang-zh

Update Chinese translation,

---------------------------------------------------------------
ruffle.mk nightly-2025-08-14 # Version: Commits on Aug 14, 2025
---------------------------------------------------------------
## What's Changed

* core: Force correct alignment for `DisplayObjectBase` by @moulins in ruffle-rs/ruffle#21313

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-08-13...nightly-2025-08-14,

---------------------------------------------------------------------------------------
thextech.mk 19726beaffb7c5337b972efbda02bef3a12c0a2e # Version: Commits on Aug 14, 2025
---------------------------------------------------------------------------------------
joystick.cpp: Put the Switch list to original place

As @ds-sloth done initially before revertion,

-----------------------------------------------------------------------------------
ymir.mk 93a656b1fb2cd43a44123b1e2ff18b58e30d45b9 # Version: Commits on Aug 14, 2025
-----------------------------------------------------------------------------------
chore(about): Update Patreon supporters list,

------------------------------------------------------
appstream.mk v1.0.6 # Version: Commits on Aug 14, 2025
------------------------------------------------------
Release version 1.0.6,

-------------------------------------------------------------------------------------
pysdl3.mk 6a00cb6150d4238c8851c62001985bdea5d5ffce # Version: Commits on Aug 07, 2025
-------------------------------------------------------------------------------------
Bump version to 'v0.9.8b8'.,

-------------------------------------------------------------------------------------------
sdl12-compat.mk cc0201143a33a399a8d4f01571cfe5fceec09df5 # Version: Commits on Aug 14, 2025
-------------------------------------------------------------------------------------------
minor clean-up and sync with latest SDL2,

------------------------------------------------------------------------------------------
devilutionx.mk 2d710174b2cd2128edaaa235351531892ca8a6ca # Version: Commits on Aug 13, 2025
------------------------------------------------------------------------------------------
Extract Hellfire table text for translation,

--------------------------------------------------------------------------------------
eduke32.mk 126f35ca8c24368f101996523935d08b269f45be # Version: Commits on Aug 13, 2025
--------------------------------------------------------------------------------------
Fix bug with unit art loading

---------------------------------------------------------------------------------------
etlegacy.mk ad6400983085d7889b6523e7144c20b12af42255 # Version: Commits on Aug 14, 2025
---------------------------------------------------------------------------------------
cgame: add cg_customCrosshairDynamicColor,

-------------------------------------------------------------------------------------------
jazz2-native.mk 8a6a72549a1440d77e5c89d20f23bd44d52671cb # Version: Commits on Aug 14, 2025
-------------------------------------------------------------------------------------------
Increased cache version,

---------------------------------------------------
nblood.mk r14258 # Version: Commits on Aug 14, 2025
---------------------------------------------------
-

----------------------------------------------------------------------------------------
openmohaa.mk 282110239eab3a65beedd19fa70fd93bd24c1da7 # Version: Commits on Aug 13, 2025
----------------------------------------------------------------------------------------
Add USE_CODEC_MAD option,

-----------------------------------------------------------------------------------
rott.mk de6786b72c12a39a7b1c418afce1dbe0f768761c # Version: Commits on Aug 14, 2025
-----------------------------------------------------------------------------------
add optional ASAN to CMakeLists.txt (#110),

------------------------------------------------------
syncthing.mk v2.0.1 # Version: Commits on Aug 14, 2025
------------------------------------------------------
## Major changes in 2.0

- Database backend switched from LevelDB to SQLite. There is a migration on

  first launch which can be lengthy for larger setups. The new database is

  easier to understand and maintain and, hopefully, less buggy.

- The logging format has changed to use structured log entries (a message

  plus several key-value pairs). Additionally, we can now control the log

  level per package, and a new log level WARNING has been inserted between

  INFO and ERROR (which was previously known as WARNING...). The INFO level

  has become more verbose, indicating the sync actions taken by Syncthing. A

  new command line flag `--log-level` sets the default log level for all

  packages, and the `STTRACE` environment variable and GUI has been updated

  to set log levels per package. The `--verbose` and `--logflags` command

  line options have been removed and will be ignored if given.

- Deleted items are no longer kept forever in the database, instead they are

  forgotten after fifteen months. If your use case require deletes to take

  effect after more than a fifteen month delay, set the

  `--db-delete-retention-interval` command line option or corresponding

  environment variable to zero, or a longer time interval of your choosing.

- Modernised command line options parsing. Old single-dash long options are

  no longer supported, e.g. `-home` must be given as `--home`. Some options

  have been renamed, others have become subcommands. All serve options are

  now also accepted as environment variables. See  `syncthing --help` and

  `syncthing serve --help` for details.

- Rolling hash detection of shifted data is no longer supported as this

  effectively never helped. Instead, scanning and syncing is faster and more

  efficient without it.

- A \default folder\ is no longer created on first startup.

- Multiple connections are now used by default between v2 devices. The new

  default value is to use three connections: one for index metadata and two

  for data exchange.

- The following platforms unfortunately no longer get prebuilt binaries for

  download at syncthing.net and on GitHub, due to complexities related to

  cross compilation with SQLite:

  - dragonfly/amd64

  - illumos/amd64 and solaris/amd64

  - linux/ppc64

  - netbsd/*

  - openbsd/386 and openbsd/arm

  - windows/arm

- The handling of conflict resolution involving deleted files has changed. A

  delete can now be the winning outcome of conflict resolution, resulting in

  the deleted file being moved to a conflict copy.

This release is also available as:

* APT repository: https://apt.syncthing.net/

* Docker image: `docker.io/syncthing/syncthing:2.0.1` or `ghcr.io/syncthing/syncthing:2.0.1`

  (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version)

## What's Changed

### Fixes

* fix: allow upgrade without config dir (fixes #10240) by @calmh in syncthing/syncthing#10241

* fix(all): various typos by @rasa in syncthing/syncthing#10242

* fix(etc): correct incantation to launch browser in Linux desktop file by @calmh in syncthing/syncthing#10246

* fix(db): handle path names that include URL special chars (fixes #10245) by @calmh in syncthing/syncthing#10247

* fix: increase default delete retention to 15 months by @calmh in syncthing/syncthing#10252

### Other

* build(deps): update (most) dependencies by @calmh in syncthing/syncthing#10243

**Full Changelog**: syncthing/syncthing@v2.0.0...v2.0.1,

----------------------------------------------------------------------------------------
doomretro.mk 41263e563eb9f3e352114c8241f18f362e1de47f # Version: Commits on Aug 14, 2025
----------------------------------------------------------------------------------------
No dropshadow for overlay text when player invulnerable,

-------------------------------------------------------------------------------------
gzdoom.mk f30fc8dd00a620227756ff0df25d3eb209ce5ebc # Version: Commits on Jul 30, 2025
-------------------------------------------------------------------------------------
mirror changes from commit '194fb9e' at https://github.com/dpjudas/vkdoom,

--------------------------------------------------------------------------------------------------
libretro-clownmdemu.mk 373d737bb3c29aac71bcb626da7906d4b6e6cca4 # Version: Commits on Aug 13, 2025
--------------------------------------------------------------------------------------------------
Bump version to v1.4.0.1.,

---------------------------------------------------------------------------------------------
libretro-fbneo.mk eb9a7542f3cb3e50d37737e0820f76699fd8a1ef # Version: Commits on Aug 14, 2025
---------------------------------------------------------------------------------------------
(libretro) update files,

------------------------------------------------------------------------------------------------
libretro-nestopia.mk 51ad831fcd9f10a02dcb0cbf398c2cd1b028765e # Version: Commits on Aug 14, 2025
------------------------------------------------------------------------------------------------
Merge pull request #99 from saulfabregwiivc/turbo-1-frame-op-add

Add \1\ option on \Turbo Pulse Speed\ option,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 78263413524030a5244e7c91dedd82a85b016acc # Version: Commits on Aug 14, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20714 from Dicot0721/lang-zh

Update Chinese translation,

--------------------------------------------------------------------------------------------
slang-shaders.mk 69e3dbb8947e749156ff1f70e32c88f3c37e6793 # Version: Commits on Aug 14, 2025
--------------------------------------------------------------------------------------------
use boolean for updated super-xbr shaders (#727),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torokati44 torokati44 torokati44 left review comments

@adrian17 adrian17 adrian17 approved these changes

Assignees
No one assigned
Labels
A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moulins @torokati44 @adrian17